Adjust aspect value based on the item type #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeon0
requested changes
Nov 3, 2023
Added Bow and Crossbow to the doublehanded weapons Co-authored-by: Jo <[email protected]>
|
Sorry, fighting with the system a bit. I accepted the suggestion and it keeps saying Changes requested so trying to figure out what's up. :-D |
aeon0
previously approved these changes
Nov 3, 2023
|
Yeah, I think even after accepting the suggestion I have to approve. Because I theory I could have other comments apart from the suggestion. Approved! :) |
|
You have to adapt the read_descr_test.py. As this is an amulet: https://github.com/aeon0/d4lf/blob/main/test/assets/item/read_descr_legendary_1920x1080_1.png. It now has different value for the aspect. (correct value for the aspect that is :) Adapt here: https://github.com/aeon0/d4lf/blob/2dbe9678ac9620d4832713927c3161bb2991575a/test/item/read_descr_test.py#L44 |
…et -> reported 22)
…ithub.com/tomas-davidovic/d4lf into dev/adjust_aspect_value_base_on_item_type
|
Adapted |
aeon0
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version reads the aspect variable value as is.
But those values are scaled by 1.5x for Amules and by 2x for two handed weapons.
I propose to scale them back down to the "canonical" values.
(I am not running Rogue, so I don't know whether Bows and Crossbows scale to 2x as well, please adjust accordingly)