Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added elementalists_aspect to the list of aspects that have variable … #15

Conversation

tomas-davidovic
Copy link
Contributor

…number on a second position

The aspect says that skills cast above 100 Mana (first number) gain XX% critical strike chance. So it is one of those "second number is the important one" cases

Copy link
Contributor

@aeon0 aeon0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. There are probably a couple more that have their variable numbers as second or third. Probably should add this to the json file to easier adapt this instead of somewhere in the code. But works for now.

@aeon0 aeon0 merged commit f55b75f into d4lfteam:main Nov 3, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants