Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug where solo aspect wasn't correctly parsed #14

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

tomas-davidovic
Copy link
Contributor

When the filter_data is just a string, then the filter_aspect on the next line was a list and would assign aspect (which has to be a global of some sort I guess, or a literal) instead of the filter_aspect. The result was that it wouldn't pick up aspects.

In general, the two lines that array-ify the filter_data seems superfluous, one should be enough (if not an array, wrap in an array)?

Copy link
Contributor

@aeon0 aeon0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thast a bug. Lets clean this up. Remove L113 and do:
aspect_name, *rest = filter_data if isinstance(filter_data, list) else [filter_data]

@tomas-davidovic
Copy link
Contributor Author

Updated as requested

@aeon0 aeon0 self-requested a review November 3, 2023 10:29
@aeon0 aeon0 merged commit 72662d8 into d4lfteam:main Nov 3, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants