Added note about Chrome being required for trade imports (#405)

d4lfteam · Oct 24, 2024 · beb941a · beb941a
1 parent 0116c46
commit beb941a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -60,6 +60,10 @@ feature request or issue reports join the [discord](https://discord.gg/YyzaPhAN6
     - Due to your local windows settings, the tool might not be able to control the mouse. Just run the tool as admin
       and it should work. If you don't want to run it as admin, you can disable the mouse control in the params.ini
       by setting `vision_mode_only` to `true`.
+- I am trying to import a trade search from diablo.trade and am getting an error that I need to install Chrome.
+    - diablo.trade has a setting enabled that will block all automated access, but we use a chrome-based browser to
+      circumvent this. For diablo.trade imports it is required that Chrome be installed. Regular build imports can
+      work with any browser.
 
 ### TTS
 
@@ -103,7 +107,7 @@ The config folder in `C:/Users/<WINDOWS_USER>/.d4lf` contains:
 | [general]                                         | Description                                                                                                                                                                                                                                                                                                                                                                                                                              |
 |---------------------------------------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
 | profiles                                          | A set of profiles separated by comma. d4lf will look for these yaml files in config/profiles and in C:/Users/WINDOWS_USER/.d4lf/profiles                                                                                                                                                                                                                                                                                                 |
-| browser                                           | Which browser to use to get builds, please make sure you pick an installed browser: chrome, edge or firefox are currently supported                                                                                                                                                                                                                                                                                                      |
+| browser                                           | Which browser to use to get builds, please make sure you pick an installed browser: chrome, edge or firefox are currently supported. Note: Trade importing can only work with Chrome and ignores this setting.                                                                                                                                                                                                                           |
 | check_chest_tabs                                  | Which chest tabs will be checked and filtered for items in case chest is open when starting the filter. You need to buy all slots. Counting is done left to right. E.g. 1,2,4 will check tab 1, tab 2, tab 4                                                                                                                                                                                                                             |
 | full_dump                                         | When using the import build feature, whether to use the full dump (e.g. contains all filter items) or not                                                                                                                                                                                                                                                                                                                                |
 | handle_rares                                      | - `filter`: Filter them based on your profiles <br>- `ignore`: Ignores all rares, vision mode shows them as blue and auto mode never junks or favorites them <br>- `junk`: Vision mode shows them always as red, auto mode always junks rares                                                                                                                                                                                            |

diff --git a/src/gui/qt_gui.py b/src/gui/qt_gui.py
@@ -152,7 +152,8 @@ def on_worker_finished():
             "https://diablo.trade/listings/items?exactPrice=true&itemType=equipment&price=50000000,999999999999&rarity=legendary&sold=true&sort=newest\n\n"
             "Please note that only legendary items are supported at the moment. The listing must also have an exact price.\n"
             "You can create such a filter by using the one above as a base and then add your custom data to it.\n"
-            f"It will then create a file based on the listings in: {IniConfigLoader().user_dir / "profiles"}"
+            f"It will then create a file based on the listings in: {IniConfigLoader().user_dir / "profiles"}\n\n"
+            "NOTE: You must have Chrome installed on your computer to use this feature."
         )
         instructions_text.setReadOnly(True)
         font_metrics = instructions_text.fontMetrics()