Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allowed in reset_index function for case with no dataloader #32

Merged
merged 1 commit into from
Oct 24, 2024
Merged

allowed in reset_index function for case with no dataloader #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions ddopai/envs/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,8 @@ def get_start_index(self,
return start_index

def reset_index(self,
start_index: Union[int,str]):
start_index: Union[int,str],
) -> bool:

"""

Expand All @@ -235,9 +236,12 @@ def reset_index(self,
self.start_index = start_index
else:
raise ValueError("start_index must be an integer or 'random'")

self.max_index = self.dataloader.len_train if self.mode == "train" else self.dataloader.len_val if self.mode == "val" else self.dataloader.len_test
self.max_index -= 1

if self.dataloader.len_train is not None:
self.max_index = self.dataloader.len_train if self.mode == "train" else self.dataloader.len_val if self.mode == "val" else self.dataloader.len_test
self.max_index -= 1
else:
self.max_index = self.start_index+self.mdp_info.horizon
self.max_index_episode = np.minimum(self.max_index, self.start_index+self.mdp_info.horizon)
if self.mode == "test" or self.mode == "val":
self.max_index_episode += 1
Expand Down
12 changes: 8 additions & 4 deletions nbs/20_environments/20_base_env/10_base_env.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,8 @@
" return start_index\n",
"\n",
" def reset_index(self,\n",
" start_index: Union[int,str]):\n",
" start_index: Union[int,str], \n",
" ) -> bool:\n",
"\n",
" \"\"\"\n",
"\n",
Expand All @@ -277,9 +278,12 @@
" self.start_index = start_index\n",
" else:\n",
" raise ValueError(\"start_index must be an integer or 'random'\")\n",
"\n",
" self.max_index = self.dataloader.len_train if self.mode == \"train\" else self.dataloader.len_val if self.mode == \"val\" else self.dataloader.len_test\n",
" self.max_index -= 1\n",
" \n",
" if self.dataloader.len_train is not None:\n",
" self.max_index = self.dataloader.len_train if self.mode == \"train\" else self.dataloader.len_val if self.mode == \"val\" else self.dataloader.len_test\n",
" self.max_index -= 1\n",
" else:\n",
" self.max_index = self.start_index+self.mdp_info.horizon\n",
" self.max_index_episode = np.minimum(self.max_index, self.start_index+self.mdp_info.horizon)\n",
" if self.mode == \"test\" or self.mode == \"val\":\n",
" self.max_index_episode += 1\n",
Expand Down