allowed for set_param to infer current shape if not new

README.md

@@ -18,11 +18,12 @@ To be written.
 To make any enviroment compatible with mushroomRL and other agents
 defined within ddopai, there are some additional requirements when
 defining the environment. Instead of inheriting from `gym.Env`, the
-environment should inherit from `ddopai.envs.base.BaseEnvironment`. This
-base class provides some additional necessary methods and attributes to
-ensure compatibility with the agents. Below are the steps to convert a
-Gym environment to a ddopai environment. We strongly recommend you to
-also look at the implementation of the NewsvendorEnv
+environment should inherit from
+[`ddopai.envs.base.BaseEnvironment`](https://opimwue.github.io/ddopai/20_environments/20_base_env/base_env.html#baseenvironment).
+This base class provides some additional necessary methods and
+attributes to ensure compatibility with the agents. Below are the steps
+to convert a Gym environment to a ddopai environment. We strongly
+recommend you to also look at the implementation of the NewsvendorEnv
 (nbs/20_environments/21_envs_inventory/20_single_period_envs.ipynb) as
 an example.
 

ddopai/utils.py

@@ -226,9 +226,19 @@ def set_param(obj,
         False, the function will raise an error if the parameter does not exist.
     """
 
+
     if input is None:
         param = None
 
+    if not new:
+        # get current shape of parameter
+        if not hasattr(self, name):
+            # if parameter is not a dict, get the shape
+            raise AttributeError(f"Parameter {name} does not exist")
+
+        if not isinstance(getattr(self, name), dict):
+            shape = getattr(self, name).shape
+
     elif isinstance(input, Parameter):
         if input.shape != shape:
             raise ValueError("Parameter shape must be equal to the shape specified for this environment parameter")

nbs/00_utils/00_utils.ipynb

@@ -668,9 +668,19 @@
     "        False, the function will raise an error if the parameter does not exist.\n",
     "    \"\"\"\n",
     "\n",
+    "\n",
     "    if input is None:\n",
     "        param = None\n",
     "\n",
+    "    if not new:\n",
+    "        # get current shape of parameter\n",
+    "        if not hasattr(self, name):\n",
+    "            # if parameter is not a dict, get the shape\n",
+    "            raise AttributeError(f\"Parameter {name} does not exist\")\n",
+    "\n",
+    "        if not isinstance(getattr(self, name), dict):\n",
+    "            shape = getattr(self, name).shape\n",
+    "\n",
     "    elif isinstance(input, Parameter):\n",
     "        if input.shape != shape:\n",
     "            raise ValueError(\"Parameter shape must be equal to the shape specified for this environment parameter\")\n",