Disk provider binary-only module reference fix #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a module that is read by the disk metadata provider references a binary-only module, the "ListModulesInDependencyOrder()" method causes an exception error that is intercepted by the Get-D365Module function in line 172. As a result, the order of the modules cannot be determined taking the dependencies into account and "ListModules" is used instead. The problem can be easily avoided by adding the model manifest of the runtime metadata provider to the "CreateDiskProvider" method in line 165. This ensures that the disk provider has all the information it needs to determine the sequence for all modules based on the dependencies.
|
Nice find! Thanks for the pr as well. @TrudAX : You might be interested in this 😄 @Splaxi : Can you do a release? We have several unreleased changes: master...development |
|
@FH-Inway - thanks. I can test it when you release it. Currently, I can't use this parameter ListModulesInDependencyOrder for a new VM, created a workaround just manually specifying a compile section |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a module that is read by the disk metadata provider references a binary-only module, the "ListModulesInDependencyOrder()" method causes an exception error that is catched by the Get-D365Module function in line 172. As a result, the order of the modules cannot be determined taking the dependencies into account and "ListModules" is used instead. The problem can be easily avoided by adding the model manifest of the runtime metadata provider to the "CreateDiskProvider" method in line 165.
This ensures that the disk provider has all the information it needs to determine the sequence for all modules based on the dependencies.