Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Upgrade Jenkins #2047

Merged
merged 6 commits into from
Feb 20, 2022
Merged

[CI] Upgrade Jenkins #2047

merged 6 commits into from
Feb 20, 2022

Conversation

AnirudhDagar
Copy link
Member

@AnirudhDagar AnirudhDagar commented Feb 19, 2022

This PR updates the infrastructure for d2l CI.

  1. Use a new master-slave approach for the Jenkins and the build servers.
  2. Remove unnecessary installation of d2lbook in static/build.yml
  3. Bump to tensorflow==2.8.0 and tensorflow-probability==0.16.0 (Based on CUDA 11.2)
  4. Update torch and mxnet cuda version. (Based on CUDA 10.2)
  5. Pin matplotlib==3.4.0 ; this is required to fix [MXNet] matplotlib >=3.5 raises TypeError with ax.plot_wireframe in MXNet ndarray #2046
  6. Fix tensorflow==2.8.0 bug in seq2seq; Thanks @cheungdaven
  7. Fix linear regression plotting bug in mxnet with numpy>=1.20. Fixes issue number one mentioned in Pin the dependencies in setup.py #2044

Changes made behind the scene:
The slave node now has multiple CUDA versions (10.2 and 11.2) for use with different frameworks.
LD_LIBRARY_PATH sets both of them in order and each library installs the framework accordingly.

@astonzhang I suggest making a merge commit instead of squashing since we have multiple unrelated changes in this single PR and in case we need to revert only a particular change then we can easily do that.

AnirudhDagar and others added 6 commits February 18, 2022 08:00
With matplotlib > 3.4 MXNet fails in plotting with many notebooks (eg. chapter_appendix-mathematics-for-deep-learning/multivariable-calculus.md) throwing the following error:
TypeError: no implementation found for 'numpy.column_stack' on types that implement __array_function__: [<class 'mxnet.numpy.ndarray'>, <class 'numpy.ndarray'>]
revise the call function in the module class.
@@ -3,11 +3,10 @@ dependencies:
- pip
- pip:
- .. # d2l
- git+https://github.com/d2l-ai/d2l-book
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep this dependency since we may keep upgrading it to enable new features

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason when I setup build.yml with d2l-book dependency, I get an error with sphinx not being available. It is collected by pip but mxtheme requires sphinx and hence errors out.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then we may need to fix it if this is an issue with the current source of d2l-book

@@ -16,7 +16,6 @@ stage("Build and Publish") {
sh label: "Build Environment", script: """set -ex
conda env update -n ${ENV_NAME} -f static/build.yml
conda activate ${ENV_NAME}
pip uninstall -y d2lbook
Copy link
Member

@astonzhang astonzhang Feb 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a workaround for the env cache (the d2lbook installation won't be triggered from build.yml since it's cached, which saves installation (>10 mins) every time a change is pushed) - in order to integrate the latest features of d2lbook we force to re-install it in this way. Maybe we can keep this for now and iterate over it after we have better ideas of env cache on Actions.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, makes sense.

@astonzhang
Copy link
Member

To accelerate the CI upgrading, I'm going to merge this PR but please address my comments in a separate PR (which won't block your integration). Thanks!

@astonzhang astonzhang merged commit a190521 into d2l-ai:master Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MXNet] matplotlib >=3.5 raises TypeError with ax.plot_wireframe in MXNet ndarray
3 participants