Avoiding $this leaking from the constructor.

cyrilverloop · Mar 5, 2021 · 71869ee · 71869ee
1 parent 48ac2af
commit 71869ee
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/Columns.php b/src/Columns.php
@@ -90,7 +90,7 @@ private function addFromArray(array $columnDatas): void
             $orderable = true;
         }
 
-        $this->add(new Column($columnDatas['data'], $searchable, $orderable));
+        $this->list[] = new Column($columnDatas['data'], $searchable, $orderable);
     }
 
     /**

diff --git a/src/Orders.php b/src/Orders.php
@@ -58,7 +58,7 @@ private function addFromArray(array $orderDatas): void
             throw new \OutOfBoundsException('orders.key.notExist');
         }
 
-        $this->add(new Order((int)$orderDatas['column'], (string)$orderDatas['dir']));
+        $this->list[] = new Order((int)$orderDatas['column'], (string)$orderDatas['dir']);
     }
 
     /**
-Original file line number
+Diff line change
@@ Expand Up / @@ -90,7 +90,7 @@ private function addFromArray(array $columnDatas): void @@
                 $orderable = true;
             }
-            $this->add(new Column($columnDatas['data'], $searchable, $orderable));
+            $this->list[] = new Column($columnDatas['data'], $searchable, $orderable);
         }
         /**
@@ Expand Down @@