Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

breaking: 14.0.0 Release #30305

Open
wants to merge 172 commits into
base: develop
Choose a base branch
from
Open

breaking: 14.0.0 Release #30305

wants to merge 172 commits into from

Conversation

jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Sep 27, 2024

BREAKING CHANGE: 14.0.0 release

⚠️ DO NOT SQUASH AND MERGE. USE A MERGE COMMIT

Checklist

Before merging release/14.0.0 into develop

  • Make sure all npm packages with breaking changes run against npm-release in circle CI. Do a dry run once ready to make sure major versions are applied to:
  • The following packages are removed and need to be deprecated in npm
    • @cypress/vue2 (already deprecated)
    • @cypress/react18
    • @cypress/angular-signals

After merging release/14.0.0 into develop

  • Make sure all npm packages with breaking changes are published as breaking changes:
    • @cypress/vite-dev-server
    • @cypress/webpack-dev-server
    • @cypress/react
    • @cypress/svelte
    • @cypress/angular
    • @cypress/schematic
  • Once major version is released, continue to give @cypress/schematic a full test with the angular cli
  • We need to make sure synk jobs now run on node 20 and not node 18

Release day

Details

Copy link

cypress bot commented Sep 27, 2024

cypress    Run #59636

Run Properties:  status check passed Passed #59636  •  git commit 85da2870fd: breaking: release version 4.0.0 of @cypress/webpack-dev-server.
Project cypress
Branch Review release/14.0.0
Run status status check passed Passed #59636
Run duration 03m 29s
Commit git commit 85da2870fd: breaking: release version 4.0.0 of @cypress/webpack-dev-server.
Committer AtofStryker
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 685
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 130
View all changes introduced in this branch ↗︎

* chore: updating v8 snapshot cache

* chore: updating v8 snapshot cache

* chore: updating v8 snapshot cache

---------

Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
@jennifer-shehane jennifer-shehane added the Cypress 14 Issues scoped for Cypress 14 label Sep 27, 2024
@jennifer-shehane jennifer-shehane changed the title feat(breaking): 14.0.0 Release breaking: 14.0.0 Release Sep 27, 2024
jennifer-shehane and others added 8 commits September 27, 2024 15:19
* chore: updating v8 snapshot cache

* chore: updating v8 snapshot cache

---------

Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
…#30307)

* Update minimum node engines

BREAKING CHANGE: Remove Node.js 16 and Node.js 21 support

* update changelog

* change entry to addresses

* trigger publish-binary pipeline on appropriate branch

* remove better-sqlite code

* Update changelog

* changelog
@jennifer-shehane jennifer-shehane marked this pull request as draft October 1, 2024 16:06
@jennifer-shehane jennifer-shehane self-assigned this Oct 1, 2024
@jennifer-shehane jennifer-shehane marked this pull request as ready for review October 1, 2024 17:25
@jennifer-shehane jennifer-shehane removed their assignment Oct 2, 2024
jennifer-shehane and others added 10 commits October 2, 2024 09:48
* chore: updating v8 snapshot cache

* chore: updating v8 snapshot cache

---------

Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
* remove foxdriver and force:gc/log:memory:pressure APIs

* Add changelog entry

* remove patched foxdriver file

* define types/spec FoundSpec without ref to Cypress namespace

* args

* chore: update unit test to still throw firefox cannot connect error if CDP fails to connect instead of the rtrying socket, which is no longer used when connecting to firefox

* Remove firefox-memory system test

---------

Co-authored-by: Cacie Prins <[email protected]>
Co-authored-by: AtofStryker <[email protected]>
* chore: updating v8 snapshot cache

* chore: updating v8 snapshot cache

---------

Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
ryanthemanuel and others added 7 commits January 2, 2025 11:44
* chore: fix various system test build failures

* rename tests
* remove experimentalSkipDomainInjection, add and deprecate injectDocumentDomain

* remove experimentalSkipDomainInjection, add injectDocumentDomain

* begin rethreading domain injection

* complete document domain transition

* move some cookie specs to separate test run

* origin and privileged commands with default docdom inject

* fix privileged channel when injecting document domain

* rm unnecessary .getOrigin abstraction in cors lib

* move remote-states in prep for refactor Replace Conditional with Polymorphism

* refactor remote states to strategy pattern

* cookie commands work as expected w cross origin bridge on different origins

* some origin tests updated

* run tests with document domain enabled

* run tests actually

* use correct config, swap conditional

* check-ts

* inject documetn domain for webkit tests

* do not exec injectDocumetnDomain in parallel

* fix ServerBase construction in tests to include cfg now

* pass cfg to ServerBase

* improved integration tests

* remove document domain checks for all server integration specs - will add injectDocumentDomain cases

* tests for injecting document domain when configured to

* square away server integration tests

* ensure cookies are set correctly, potentially

* errors pkg snapshots

* fix config tests

* fixing config tests

* somewhat improves tests for cors policies in packages/network

* fix ts err in server-base

* enable injectDocumentDomain for cy in cy tests

* fix Policy type ref

* refactor cypress-schematic ct spec to be less prone to timeouts

* run vite-dev-server tests with injectDocumentDomain

* rm document domain assertion from page_loading system test

* add system tests that test with injectDocumentDomain and others that test with cy.origin

* fix results_spec snapshot

* update experimentalSkipDomainInjection system test

* different behavior for certain net_stubbing tests based on injectDocumentDomain or not

* fix ts

* extract origin key logic from remote states, for now

* move server-base and response-middleware over to new pattern

* WIP - reentry

* fix build, remove console.log

* check-ts

* fix spec frame injection

* remove injection for localhost

* mostly fix vite-dev-server app integration tests

* fix codeframe in certain cases in chrome

* drop internal stack frames from stacks intended for determining code frame data

* some improvements to vite ct error codeframes

* fix proxy unit tests to use document domain injection util class

* rm .only

* fix all vite ct error specs

* rm console.log

* slight refactor to util class to make easier to test

* fix refactor - missing rename in files.js

* several tests do not set testingtype in config, so just check against component instead of checking for e2e

* revert changes to getInvocationDetails to see if that breaks tests

* re-enable stack stripping in invocation details for chrome

* new snapshots with more accurate invocation details

* test for same-site cross-origin cookie behavior

* ignore window.top ts errors

* revert forcing injectDocumentDomain in vite-dev-server cy config

* fix normalized whitespace for firefox "loading_failed" error

* always trim trailing wsp from stack before appending additional content

* force normalization of whitespace to three \n when adding additional stack details

* normalize wsp between stack and additional stack to "\n  \n" in firefox

* remove stack_utils attempt at normalizing wsp

* various cleanup: remove commented console logs, add more detailed comments

* add on links to error messages

* remove experimentalSkipDomainInjection from exported type defs

* Update system-tests/test/experimental_skip_domain_injection_spec.ts

Co-authored-by: Bill Glesias <[email protected]>

* Update packages/driver/cypress/e2e/e2e/origin/cookie_misc.cy.ts

Co-authored-by: Bill Glesias <[email protected]>

* no need to coerce a boolean value to a booleanc

* export base config from primary cypress config in driver for use in inject-document-domain test subset

* lift experimentalSkipDomainInjection breaking option to root

* rollback config/options changes

* rm invalid comment

* use hostname instead of origin to create cookie from automation cookie

* clarify stack regex in results_spec

* lint

* take a stab at the changelog entries for this

* Update cli/CHANGELOG.md

Co-authored-by: Ryan Manuel <[email protected]>

* Update cli/CHANGELOG.md

Co-authored-by: Ryan Manuel <[email protected]>

* reenable locally-failing test

* changelog

* snapshot updatesfor experimental skip domain injection err msg

* remove packageManager declaration in package.json

---------

Co-authored-by: Bill Glesias <[email protected]>
Co-authored-by: Jennifer Shehane <[email protected]>
Co-authored-by: Ryan Manuel <[email protected]>
Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
* chore: clean up experimentalSkipDomainInjection removal

* rm corepack yarn line

* update snapshots

* rm dead code, update error message
jennifer-shehane and others added 4 commits January 7, 2025 11:47
Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com>
Copy link
Contributor

@AtofStryker AtofStryker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

semantic commits for npm release are not for npm packages. in the process of fixing this but until fix DO NOT MERGE this PR

@AtofStryker AtofStryker self-assigned this Jan 7, 2025
BREAKING CHANGE: Cypress 14 drops support for Angular 13-16. Angular 17.2 and up is supported.
BREAKING CHANGE: Cypress 14 drops support for Angular 13-16. Angular 17.2 and up is supported.
BREAKING CHANGE: Cypress 14 drops support for React 16-17. React 18 and up is supported.
BREAKING CHANGE: Cypress 14 drops support for Svelte 3-4. Svelte 5 is supported.
BREAKING CHANGE: Cypress 14 drops support forVite 2-3. Vite 4 and up is supported.
BREAKING CHANGE: Cypress 14 drops support for webpack-dev-server 3. webpack/webpack-dev-server 4 and 5 are supported. @cypress/webpack-dev-server also ships with webpack-dev-server v5 by default.
@AtofStryker AtofStryker self-requested a review January 7, 2025 22:10
Copy link
Contributor

@AtofStryker AtofStryker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package versions are now correct and will be published correctly on merge commit into develop
Screenshot 2025-01-07 at 5 10 14 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cypress 14 Issues scoped for Cypress 14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants