Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add percy/cli to packages to fix percy not found error #1430

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Nov 14, 2023

Percy was not working for some time because the token was missing - fixed here: #1416

For some reason percy is not finding the command/cli to run after that. See CircleCI failure: #1424

Adding percy/cli directly to resolve. This used to use npx, but now we use yarn.

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c126cd6) 93.89% compared to head (22fa51f) 93.89%.
Report is 8 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1430   +/-   ##
========================================
  Coverage    93.89%   93.89%           
========================================
  Files           95       95           
  Lines         1606     1606           
  Branches       256      256           
========================================
  Hits          1508     1508           
  Misses          98       98           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Nov 14, 2023

1 flaky test on run #6186 ↗︎

0 448 2 0 Flakiness 1

Details:

Add percy/cli to packages to fix percy not found error
Project: cypress-realworld-app Commit: 22fa51f9e4
Status: Passed Duration: 28:47 💡
Started: Nov 14, 2023 7:41 PM Ended: Nov 14, 2023 8:10 PM
Flakiness  cypress/tests/ui/transaction-feeds.spec.ts • 1 flaky test • UI - Chrome - Mobile

View
Output

Test Artifacts
Transaction Feed > renders and paginates all transaction feeds > paginates personal transaction feed Test Replay Screenshots

Review all test suite changes for PR #1430 ↗︎

@jennifer-shehane jennifer-shehane merged commit 0e6602e into develop Nov 14, 2023
31 checks passed
@jennifer-shehane jennifer-shehane deleted the fix-percy branch November 14, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants