Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CyConf followups #5961

Merged
merged 47 commits into from
Oct 24, 2024
Merged

CyConf followups #5961

merged 47 commits into from
Oct 24, 2024

Conversation

jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Oct 22, 2024 •
edited
Loading

@jennifer-shehane jennifer-shehane self-assigned this Oct 22, 2024
@cypress Cypress
Copy link

cypress bot commented Oct 23, 2024 •
edited
Loading

cypress-documentation    Run #20

Run Properties:  status check passed Passed #20  •  git commit 3f0b903c62: move supportFile config option to e2e
Project cypress-documentation
Branch Review cy-conf-followups
Run status status check passed Passed #20
Run duration 03m 36s
Commit git commit 3f0b903c62: move supportFile config option to e2e
Committer Jennifer Shehane
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 279
View all changes introduced in this branch ↗︎
UI Coverage  10.91%
  Untested elements 1796  
  Tested elements 3  
Accessibility  95.78%
  Failed rules  2 critical   5 serious   4 moderate   0 minor
  Failed elements 578  

emilyrohrbough
emilyrohrbough reviewed Oct 23, 2024
View reviewed changes
cypress/support/commands.ts Outdated
@@ -0,0 +1,37 @@
/// <reference types="cypress" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to check this in?

emilyrohrbough
emilyrohrbough reviewed Oct 23, 2024
View reviewed changes
cypress/fixtures/example.json Outdated
@@ -0,0 +1,5 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we use this fixture?

emilyrohrbough
emilyrohrbough reviewed Oct 23, 2024
View reviewed changes
cypress/support/e2e.ts Outdated
@@ -0,0 +1,20 @@
// ***********************************************************
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should configure this to false

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yah just didn't even look at these, I'll turn them off

emilyrohrbough
emilyrohrbough reviewed Oct 23, 2024
View reviewed changes
docs/cloud/account-management/billing-and-usage.mdx
Comment on lines +8 to +15
:::info

##### <Icon name="question-circle" color="#42a1c0" /> What you'll learn

- How to view billing and usage information
- How to request an Open Source Plan

:::
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the What you'll learn needed? I find these badges are pretty distracting and usually explained by the sub nav titles

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a long convo with Brian about the info sections and we decided to keep them. They're not consistent on every page, but I do see the value outside of the side nav. Plus not everyone see the side nav on mobile.

@emilyrohrbough
Copy link
Member

The Cloud Setup is a bit awkward with the addition of the what you'll learn to each cloud doc page because it doesn't use an icon + title. Should we add a title or is there a better color we can use for this to stand out?
https://deploy-preview-5961--cypress-docs.netlify.app/cloud/get-started/setup

@emilyrohrbough
Copy link
Member

Possibly leverage the "star" used here: https://deploy-preview-5961--cypress-docs.netlify.app/cloud/features/flaky-test-management#Flake-Detection?

@jennifer-shehane
Copy link
Member Author

@emilyrohrbough I left that Cloud setup page as it has been. Those sections are oddly placed imo about the trials, so I agree.

@jennifer-shehane jennifer-shehane merged commit 961fc0c into main Oct 24, 2024
10 checks passed
@jennifer-shehane jennifer-shehane deleted the cy-conf-followups branch October 24, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilyrohrbough emilyrohrbough emilyrohrbough approved these changes

@marktnoonan marktnoonan Awaiting requested review from marktnoonan

Assignees

@jennifer-shehane jennifer-shehane

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Install cypress link doesn't work Broken doc links to Cypress Cloud
2 participants
@jennifer-shehane @emilyrohrbough