Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter unrecognized from extra URI parameters IAW BIP21 #935

Merged
merged 8 commits into from
Aug 27, 2024
Merged

Conversation

sneurlax
Copy link
Member

@sneurlax sneurlax commented Jul 11, 2024

Closes #567

Tasks:

TODO refer to BIP21 to see if any other params are required

Closes #567 #567

TODO refer to BIP21 to see if any other params are required
@sneurlax sneurlax marked this pull request as draft July 11, 2024 23:57
@sneurlax
Copy link
Member Author

Converted to draft pending more testing. Or we can merge and test w/ testers :)

@sneurlax
Copy link
Member Author

sneurlax commented Jul 16, 2024

Tested and this mostly works, but the address is considered invalid after pasting it:
Screenshot from 2024-07-16 10-45-02

So this needs more work. It's a valid address, I got it from the Receive screen and added ?asdf as in bitcoincash:qp07gms9yzj9ykj74ervscc8zd89gwe23cark3uk2r?asdf

I also need to make sure that mobile send screens--and really all opportunities to paste URIs--are covered by this PR's logic.

@julian-CStack
Copy link
Collaborator

We should expand on the parse util to handle various types of payment uris (bitcoin based, monero based, etc).
There are more than 3 valid keys/params in the standards so this needs some more work for sure.
The parsing of the uri should be centralized and return a common object with the values required for the gui.

The PR currently only affects the main desktop send screen. Nothing on mobile and possibly other send screens on desktop will not work with this either at the moment.

@sneurlax
Copy link
Member Author

sneurlax commented Aug 27, 2024

Re:

Tested and this mostly works, but the address is considered invalid after pasting it ... So this needs more work. It's a valid address, I got it from the Receive screen and added ?asdf as in bitcoincash:qp07gms9yzj9ykj74ervscc8zd89gwe23cark3uk2r?asdf

This issue has been resolved by b73628d

instead of duplicating logic
@sneurlax sneurlax marked this pull request as ready for review August 27, 2024 21:56
@julian-CStack julian-CStack merged commit dbc5fb7 into staging Aug 27, 2024
1 check failed
@sneurlax sneurlax deleted the uri branch August 27, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants