Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds preliminary typings for Typescript #29

Merged
merged 1 commit into from
Dec 12, 2016

Conversation

aravantv
Copy link
Contributor

@aravantv aravantv commented Dec 4, 2016

Initial contribution to Issue #26.

Provides:

  • (Xstream-only) typing for Collection and pluck
  • inline documentation for both functions

Still to do:

  • typing for non-Xstream libraries (can it simply be done by typing makeCollection? if not, can typing be factorized as easy as the code?)
  • typing for gather and merge

@Widdershin
Copy link
Member

Sorry for the delay in response.

This looks really good! I like the union type for adding sources together. I haven't really used generics in TS yet so this is informative.

I can merge this now if you like or I can wait until we've amassed a full definition.

@aravantv
Copy link
Contributor Author

I would merge it now, cause it's doing the job for me for now, so I can hardly promise that I will have time to improve it much in a close future... Sorry :-(

@Widdershin
Copy link
Member

@aravantv great, I'll merge it now. Thanks for contributing this! It's a great start on a definition. I especially like the documentation.

@Widdershin Widdershin merged commit afd9fe2 into cyclejs:master Dec 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants