Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting precision and scale through attributes #148

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Conversation

msmakouz
Copy link
Member

@msmakouz msmakouz commented Dec 18, 2023

What was changed

Closes: #149

  • Add tests
  • Make a fix

@msmakouz msmakouz self-assigned this Dec 18, 2023
@msmakouz msmakouz changed the title Adding tests with setting precision and scale through attributes Fix setting precision and scale through attributes Dec 18, 2023
@msmakouz msmakouz requested a review from roxblnfk December 18, 2023 18:06
@msmakouz msmakouz added this to the 2.7.x milestone Dec 18, 2023
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0b4d063) 95.10% compared to head (905997d) 95.10%.

Additional details and impacted files
@@            Coverage Diff            @@
##                2.x     cycle/orm#148   +/-   ##
=========================================
  Coverage     95.10%   95.10%           
  Complexity     1812     1812           
=========================================
  Files           129      129           
  Lines          4987     4987           
=========================================
  Hits           4743     4743           
  Misses          244      244           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roxblnfk roxblnfk merged commit bbdb864 into 2.x Dec 18, 2023
42 checks passed
@roxblnfk roxblnfk deleted the bugfix/decimal-attr branch December 18, 2023 20:26
@roxblnfk roxblnfk removed this from the 2.7.x milestone Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Schema diff fails when decimal column precision defined as positional arg
2 participants