-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add varbinary
support in MySQL
#146
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #146 +/- ##
============================================
+ Coverage 95.03% 95.04% +0.01%
- Complexity 1798 1805 +7
============================================
Files 128 128
Lines 4952 4965 +13
============================================
+ Hits 4706 4719 +13
Misses 246 246 ☔ View full report in Codecov by Sentry. |
1 task
roxblnfk
reviewed
Nov 28, 2023
roxblnfk
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Varbinary
Support for
varbinary
in MySQL has been added with the ability to specify size. When specifying a binary type with size, a column of type varbinary with the required size will be automatically created.Prior to these changes, a column of type
blob
was created and the size was ignored.Closes: #144
Size attribute
The size attribute is explicitly used in certain column types. Prior to these changes, for example, mistakenly specifying a size on a column of type json would lead to the generation of erroneous migrations.