Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC - Implements Conjur OSS database as postgresql Helm subchart #83

Closed
wants to merge 1 commit into from

Conversation

diverdane
Copy link
Contributor

@diverdane diverdane commented Oct 7, 2020

This branch implements the Conjur OSS backend database as a
Helm subchart. The Helm subchart imports from the bitnami/postgreql chart.

Needs some work to:

  • Autogenerate a Postgresql password by default
  • Set the database.url value based on that password
  • Use checksum/config annotations with hashes to selectively
    recreate pods in the Conjur-OSS cluster but not the Postgresql
    cluster.

To deploy Conjur with a Postgresql database, run:

DATA_KEY="$(docker run --rm cyberark/conjur data-key generate)"
CONJUR_NAMESPACE=conjur-with-subchart
PG_PASSWORD=0mbkLSg9ah
PG_NAMESPACE="$CONJUR_NAMESPACE"

kubectl create namespace "${CONJUR_NAMESPACE}"
helm install \
   -n "${CONJUR_NAMESPACE}" \
   --set dataKey="${DATA_KEY}" \
   --set rbac.create=false \
   --set database.url="postgres://postgres:${PG_PASSWORD}@conjur-oss-postgresql.${PG_NAMESPACE}.svc.cluster.local:5432/postgres" \
   --set postgresql.postgresqlPassword="${PG_PASSWORD}" \
   conjur-oss .

What does this PR do?

  • What's changed? Why were these changes made?
  • How should the reviewer approach this PR, especially if manual tests are required?
  • Are there relevant screenshots you can add to the PR description?

What ticket does this PR close?

Resolves #86

Checklists

Change log

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or
  • This PR does not require updating any documentation

This branch implements the Conjur OSS backend database as a
Helm subchart. The Helm subchart imports from the bitnami/postgreql chart.

Needs some work to:
- Autogenerate a Postgresql password by default
- Set the database.url value based on that password
- Use checksum/config annotations with hashes to selectively
  recreate pods in the Conjur-OSS cluster but not the Postgresql
  cluster.

To deploy Conjur with a Postgresql database, run:

```
DATA_KEY="$(docker run --rm cyberark/conjur data-key generate)"
CONJUR_NAMESPACE=conjur-with-subchart
PG_PASSWORD=0mbkLSg9ah
PG_NAMESPACE="$CONJUR_NAMESPACE"

kubectl create namespace "${CONJUR_NAMESPACE}"
helm install \
   -n "${CONJUR_NAMESPACE}" \
   --set dataKey="${DATA_KEY}" \
   --set rbac.create=false \
   --set database.url="postgres://postgres:${PG_PASSWORD}@conjur-oss-postgresql.${PG_NAMESPACE}.svc.cluster.local:5432/postgres" \
   --set postgresql.postgresqlPassword="${PG_PASSWORD}" \
   conjur-oss .
```
@diverdane diverdane requested a review from a team as a code owner October 7, 2020 03:39
@diverdane diverdane self-assigned this Oct 13, 2020
@diverdane diverdane marked this pull request as draft October 13, 2020 13:36
@izgeri izgeri changed the base branch from master to main May 26, 2021 17:40
@izgeri izgeri changed the base branch from main to master May 26, 2021 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Document use of or add subchart for bitnami/postgresql
2 participants