Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

移除数据组件冗余的构造函数,将大部分构造操作移动至对应的工厂函数 #225

Merged

Conversation

zhaoxi-scut
Copy link
Member

Pull Request 合并请求准备清单

详情参见此处

  • 我同意在 Apache 2 开源许可下为本项目做贡献
  • 此 pull request 是在正确的分支上提出的
  • 此 pull request 有对应的错误报告或其他待改进的内容
  • 我本地的 RMVL 进行了单元测试、性能测试,有对应的测试数据
  • 我提交的 feature 有很好的文档记录,并且可以使用 CMake 项目构建示例代码

具体内容

  • 移除所有 feature 组件以及 rm::Armor 冗余的构造函数,将大部分构造操作移动至对应的工厂函数 make_feature 以及 make_combo 当中

@zhaoxi-scut zhaoxi-scut added the optimization 代码重构、功能优化 label Feb 14, 2025
@zhaoxi-scut zhaoxi-scut added this to the 2.3.0 milestone Feb 14, 2025
@TooPretty0108 TooPretty0108 merged commit 516ab61 into cv-rmvl:2.x Feb 14, 2025
8 checks passed
@zhaoxi-scut zhaoxi-scut deleted the data-components-remove-constructors branch February 15, 2025 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimization 代码重构、功能优化
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants