Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed the streaming bug #75

Merged
merged 2 commits into from
Nov 15, 2024
Merged

fixed the streaming bug #75

merged 2 commits into from
Nov 15, 2024

Conversation

ChaoPang
Copy link
Contributor

@ChaoPang ChaoPang commented Nov 15, 2024 •
edited
Loading

  • The filter function should not be applied to the DatasetDict of IterableDatasets, instead, the filter needs to be applied to each dataset in a for-loop
  • The test split is renamed to the validation split to ensure the consistent dataset names throughout the pretrain runner

@ChaoPang ChaoPang linked an issue Nov 15, 2024 that may be closed by this pull request
Problems running the sample script #73
Closed
@ChaoPang ChaoPang marked this pull request as ready for review November 15, 2024 04:23
@ChaoPang ChaoPang requested a review from ksdkalluri November 15, 2024 14:06
ksdkalluri
ksdkalluri approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@ksdkalluri ksdkalluri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ChaoPang ChaoPang merged commit 3fee9ab into main Nov 15, 2024
4 checks passed
@ChaoPang ChaoPang deleted the tutorial_bugs branch November 15, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksdkalluri ksdkalluri ksdkalluri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problems running the sample script
2 participants
@ChaoPang @ksdkalluri