Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SOL-127: Add Ruby 3 support to gem #2

Merged
merged 33 commits into from
May 20, 2022
Merged

SOL-127: Add Ruby 3 support to gem #2

merged 33 commits into from
May 20, 2022

Conversation

m-dwyer
Copy link

@m-dwyer m-dwyer commented Apr 20, 2022 •
edited
Loading

A merge of this pull request here: collectiveidea#1158

This will provide Ruby 3.0 support to the delayed_job gem

webhoernchen and others added 20 commits December 22, 2020 11:28
@webhoernchen
* Support for Ruby 3.0 added
d5e43b4
@webhoernchen
* debug messages commented out
7c73130
@webhoernchen
* syntax fixed
bfdabfe
@webhoernchen
* Syntax fixed
90faa82
@webhoernchen
* Syntax fixed
34dc5c9
@webhoernchen
* specs added
c93b433
@webhoernchen
* Ruby 3.0 added
87a2aef
@webhoernchen
* ci fixed
8903aaa
@webhoernchen
* dependencies fixed
25b0a43
@webhoernchen
* rubocop fixed
7819cb8
@webhoernchen
* specs for older rails versions fixed
fff4e1e
@webhoernchen
* specs for old rails versions fixed
0afc6a2
@webhoernchen
+ specs for old rails versions fixed
1e97748
@jdelStrother
Capture kwargs separately in PerformableMethod
e8b520e 
We're going to need to explicitly separate kwargs and hash parameters to
fix ruby 3 compatibility
@jdelStrother
Try to maintain support for ruby 2.6
f379d6a
@m-dwyer
Merge remote-tracking branch 'delayed-job-ruby3/ruby3' into ruby3
2151092
@m-dwyer
Add initional github specific files, including actions, pull request …
b5fff18 
…templates, teams file
@m-dwyer
Add ruby workflow based on existing event_framework to run tests
a1357f7
@m-dwyer
Fix expectations for hash passed inside args. args array will be unpa…
de28325 
…cked, but not internal hash
@m-dwyer
Upgrade rubocop for ruby 3 support, and silence offenses
eb3d8e0
@m-dwyer m-dwyer changed the title SOL-105: Add Ruby 3 support to gem SOL-127: Add Ruby 3 support to gem May 4, 2022
@m-dwyer m-dwyer requested review from dabarrell and juliohr May 4, 2022 01:17
juliohr
juliohr reviewed May 4, 2022
View reviewed changes
.github/CODEOWNERS Outdated Show resolved Hide resolved
dabarrell
dabarrell previously requested changes May 4, 2022
View reviewed changes
Copy link

@dabarrell dabarrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor changes, but besides that looks good

.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/teams.yml Outdated Show resolved Hide resolved
.github/workflows/team-labeler.yml Outdated Show resolved Hide resolved
.github/workflows/ruby.yml Outdated Show resolved Hide resolved
@m-dwyer m-dwyer requested a review from dabarrell May 4, 2022 03:25
@m-dwyer m-dwyer requested a review from juliohr May 9, 2022 05:03
dNitza
dNitza reviewed May 12, 2022
View reviewed changes
Copy link

@dNitza dNitza left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @m-dwyer this looks good! I have just left a question about the kwargs getter, and a comment about the definition of method_missing, but the rest looks 👍🏽 to me.

lib/delayed/performable_method.rb Outdated Show resolved Hide resolved
lib/delayed/performable_method.rb Show resolved Hide resolved
@m-dwyer m-dwyer requested a review from dNitza May 13, 2022 03:51
dNitza
dNitza approved these changes May 13, 2022
View reviewed changes
Copy link

@dNitza dNitza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @m-dwyer :) This looks good to me! Keen to see how the verification bits pan out :D

@m-dwyer m-dwyer dismissed dabarrell’s stale review May 13, 2022 06:21

changes made

@m-dwyer m-dwyer merged commit 324347b into master May 20, 2022
@dabarrell dabarrell deleted the ruby3 branch May 20, 2022 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dNitza dNitza dNitza approved these changes

@dabarrell dabarrell Awaiting requested review from dabarrell

@juliohr juliohr Awaiting requested review from juliohr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@m-dwyer @dNitza @juliohr @dabarrell @webhoernchen @jdelStrother