Merge pull request chinmina#61 from jamestelfer/release-mod

ci: fix errors in release process
cultureamp · Sep 21, 2024 · bad5f94 · bad5f94
2 parents 58e68fe + 2c64718
commit bad5f94
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml
@@ -16,7 +16,7 @@ permissions:
 jobs:
   goreleaser:
     # deploy with the correct environment to allow DockerHub access
-    environment: "Publish"
+    environment: 'Publish'
 
     runs-on: ubuntu-latest
     steps:
@@ -39,8 +39,8 @@ jobs:
       - name: Login to Docker Hub
         uses: docker/login-action@v3
         with:
-          username: ${{ secrets.DOCKERHUB_USER }}
-          password: ${{ secrets.DOCKERHUB_TOKEN }}
+          username: '${{ vars.DOCKERHUB_USER }}'
+          password: '${{ secrets.DOCKERHUB_TOKEN }}'
 
       - name: Release
         uses: goreleaser/goreleaser-action@v5

diff --git a/.goreleaser.yaml b/.goreleaser.yaml
@@ -23,12 +23,13 @@ builds:
 # If you do this locally, sign with an OAuth identity you don't mind being permanently
 # published to a transparency log.
 binary_signs:
-  - cmd: './ci-only.sh'
+  - signature: '${artifact}.cosign.bundle'
+    cmd: './ci-only.sh'
     args:
       - "cosign"
       - "sign-blob"
       - "${artifact}"
-      - "--bundle=${artifact}.cosign.bundle"
+      - "--bundle=${signature}"
       - "--yes" # needed on cosign 2.0.0+
     output: false # the necessary output is the .cosign.bundle file