Add new methods for attachments, hooks, meta #67
Merged
+927
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Adds three new methods in our polyglot, test case-centric interface:
findAttachmentsBy(TestStepFinished)
returns an array of attachments.TestStepFinished
makes the most sense as the starting point because it has both thetestStepId
to identify the step, and thetestCaseStartedId
to identify the test case attempt.findHookBy(TestStep)
returns an optionalHook
, natural cousin offindPickleStepBy(TestStep)
findMeta()
returns the Meta message if presentAlso, fixes a bug in the old attachment-related method in JavaScript, which made an assumption an attachment would always be tied to a
testStepId
, which will not be the case once cucumber/messages#102 is implemented in runners.⚡️ What's your motivation?
Required for work on React components for the HTML formatter in cucumber/html-formatter#283
🏷️ What kind of change is this?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.