Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cubesql): Use pushdown-pullup scheme for FilterSimplifyReplacer #9278

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

[WIP] fix(cubesql): Use pushdown-pullup scheme for FilterSimplifyRepl…

7df76e1
Select commit
Loading
Failed to load commit list.
Draft

fix(cubesql): Use pushdown-pullup scheme for FilterSimplifyReplacer #9278

[WIP] fix(cubesql): Use pushdown-pullup scheme for FilterSimplifyRepl…
7df76e1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 26, 2025 in 0s

83.60% (-0.05%) compared to 1dfa10d

View this Pull Request on Codecov

83.60% (-0.05%) compared to 1dfa10d

Details

Codecov Report

Attention: Patch coverage is 97.02233% with 12 lines in your changes missing coverage. Please review.

Project coverage is 83.60%. Comparing base (1dfa10d) to head (7df76e1).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...besql/cubesql/src/compile/rewrite/rules/filters.rs 95.83% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9278      +/-   ##
==========================================
- Coverage   83.65%   83.60%   -0.05%     
==========================================
  Files         227      227              
  Lines       81773    82030     +257     
==========================================
+ Hits        68409    68584     +175     
- Misses      13364    13446      +82     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.