Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cubesql): Fix clippy warnings in cubesql, part 2 #9262

Merged
merged 14 commits into from
Feb 24, 2025

refactor(cubesql): Fix op_ref warning

87123c5
Select commit
Loading
Failed to load commit list.
Merged

refactor(cubesql): Fix clippy warnings in cubesql, part 2 #9262

refactor(cubesql): Fix op_ref warning
87123c5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Feb 24, 2025 in 1s

29.34% of diff hit (target 83.57%)

View this Pull Request on Codecov

29.34% of diff hit (target 83.57%)

Annotations

Check warning on line 63 in rust/cubesql/cubesql/src/compile/engine/df/optimizers/utils.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

rust/cubesql/cubesql/src/compile/engine/df/optimizers/utils.rs#L63 

Added line #L63 was not covered by tests

Check warning on line 65 in rust/cubesql/cubesql/src/compile/engine/df/optimizers/utils.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

rust/cubesql/cubesql/src/compile/engine/df/optimizers/utils.rs#L65 

Added line #L65 was not covered by tests

Check warning on line 80 in rust/cubesql/cubesql/src/compile/engine/df/optimizers/utils.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

rust/cubesql/cubesql/src/compile/engine/df/optimizers/utils.rs#L80 

Added line #L80 was not covered by tests

Check warning on line 83 in rust/cubesql/cubesql/src/compile/engine/df/optimizers/utils.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

rust/cubesql/cubesql/src/compile/engine/df/optimizers/utils.rs#L83 

Added line #L83 was not covered by tests

Check warning on line 99 in rust/cubesql/cubesql/src/compile/engine/df/optimizers/utils.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

rust/cubesql/cubesql/src/compile/engine/df/optimizers/utils.rs#L99 

Added line #L99 was not covered by tests

Check warning on line 102 in rust/cubesql/cubesql/src/compile/engine/df/optimizers/utils.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

rust/cubesql/cubesql/src/compile/engine/df/optimizers/utils.rs#L102 

Added line #L102 was not covered by tests

Check warning on line 118 in rust/cubesql/cubesql/src/compile/engine/df/optimizers/utils.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

rust/cubesql/cubesql/src/compile/engine/df/optimizers/utils.rs#L118 

Added line #L118 was not covered by tests

Check warning on line 121 in rust/cubesql/cubesql/src/compile/engine/df/optimizers/utils.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

rust/cubesql/cubesql/src/compile/engine/df/optimizers/utils.rs#L121 

Added line #L121 was not covered by tests

Check warning on line 151 in rust/cubesql/cubesql/src/compile/engine/df/optimizers/utils.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

rust/cubesql/cubesql/src/compile/engine/df/optimizers/utils.rs#L151 

Added line #L151 was not covered by tests

Check warning on line 215 in rust/cubesql/cubesql/src/compile/engine/df/optimizers/utils.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

rust/cubesql/cubesql/src/compile/engine/df/optimizers/utils.rs#L214-L215 

Added lines #L214 - L215 were not covered by tests

Check warning on line 252 in rust/cubesql/cubesql/src/compile/engine/df/optimizers/utils.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

rust/cubesql/cubesql/src/compile/engine/df/optimizers/utils.rs#L252 

Added line #L252 was not covered by tests

Check warning on line 286 in rust/cubesql/cubesql/src/compile/engine/df/optimizers/utils.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

rust/cubesql/cubesql/src/compile/engine/df/optimizers/utils.rs#L286 

Added line #L286 was not covered by tests

Check warning on line 313 in rust/cubesql/cubesql/src/compile/engine/df/optimizers/utils.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

rust/cubesql/cubesql/src/compile/engine/df/optimizers/utils.rs#L313 

Added line #L313 was not covered by tests

Check warning on line 332 in rust/cubesql/cubesql/src/compile/engine/df/optimizers/utils.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

rust/cubesql/cubesql/src/compile/engine/df/optimizers/utils.rs#L332 

Added line #L332 was not covered by tests

Check warning on line 425 in rust/cubesql/cubesql/src/compile/engine/df/optimizers/utils.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

rust/cubesql/cubesql/src/compile/engine/df/optimizers/utils.rs#L425 

Added line #L425 was not covered by tests

Check warning on line 429 in rust/cubesql/cubesql/src/compile/engine/df/optimizers/utils.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

rust/cubesql/cubesql/src/compile/engine/df/optimizers/utils.rs#L429 

Added line #L429 was not covered by tests

Check warning on line 436 in rust/cubesql/cubesql/src/compile/engine/df/optimizers/utils.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

rust/cubesql/cubesql/src/compile/engine/df/optimizers/utils.rs#L435-L436 

Added lines #L435 - L436 were not covered by tests

Check warning on line 450 in rust/cubesql/cubesql/src/compile/engine/df/optimizers/utils.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

rust/cubesql/cubesql/src/compile/engine/df/optimizers/utils.rs#L450 

Added line #L450 was not covered by tests

Check warning on line 457 in rust/cubesql/cubesql/src/compile/engine/df/optimizers/utils.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

rust/cubesql/cubesql/src/compile/engine/df/optimizers/utils.rs#L457 

Added line #L457 was not covered by tests

Check warning on line 284 in rust/cubesql/cubesql/src/compile/engine/df/scan.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

rust/cubesql/cubesql/src/compile/engine/df/scan.rs#L284 

Added line #L284 was not covered by tests

Check warning on line 331 in rust/cubesql/cubesql/src/compile/engine/df/scan.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

rust/cubesql/cubesql/src/compile/engine/df/scan.rs#L331 

Added line #L331 was not covered by tests

Check warning on line 975 in rust/cubesql/cubesql/src/compile/engine/df/scan.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

rust/cubesql/cubesql/src/compile/engine/df/scan.rs#L975 

Added line #L975 was not covered by tests

Check warning on line 1000 in rust/cubesql/cubesql/src/compile/engine/df/scan.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

rust/cubesql/cubesql/src/compile/engine/df/scan.rs#L1000 

Added line #L1000 was not covered by tests

Check warning on line 1050 in rust/cubesql/cubesql/src/compile/engine/df/scan.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

rust/cubesql/cubesql/src/compile/engine/df/scan.rs#L1050 

Added line #L1050 was not covered by tests

Check warning on line 1140 in rust/cubesql/cubesql/src/compile/engine/df/scan.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

rust/cubesql/cubesql/src/compile/engine/df/scan.rs#L1140 

Added line #L1140 was not covered by tests
View more details on Codecov