Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cubeclient): Add short_title to dimensions and measures #9256

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

MazterQyou
Copy link
Member

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made

This PR adds short_title field to measures and dimensions meta in cubeclient.

@MazterQyou MazterQyou requested review from a team as code owners February 21, 2025 06:23
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 93.10345% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.56%. Comparing base (1203291) to head (c0c6e02).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...ql/cubeclient/src/models/v1_cube_meta_dimension.rs 0.00% 1 Missing ⚠️
...esql/cubeclient/src/models/v1_cube_meta_measure.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9256      +/-   ##
==========================================
- Coverage   83.57%   83.56%   -0.01%     
==========================================
  Files         227      227              
  Lines       81618    81647      +29     
==========================================
+ Hits        68210    68229      +19     
- Misses      13408    13418      +10     
Flag Coverage Δ
cubesql 83.56% <93.10%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 LGTM!

@MazterQyou MazterQyou force-pushed the cubeclient/short-title branch from f80e78e to c0c6e02 Compare February 21, 2025 10:44
@MazterQyou MazterQyou merged commit 584b3dc into master Feb 21, 2025
70 checks passed
@MazterQyou MazterQyou deleted the cubeclient/short-title branch February 21, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants