fix(backend-native): Handle closed channel on Rust side #9242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9242 +/- ##
=======================================
Coverage 83.56% 83.57%
=======================================
Files 227 227
Lines 81618 81618
=======================================
+ Hits 68206 68210 +4
+ Misses 13412 13408 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ovr
approved these changes
Feb 19, 2025
DataFusion can execute complex queries, containing multiple CubeScans, specifically multiple `CubeScanExecutionPlan` in physical plan `CubeScanExecutionPlan`s can be executed concurrently, and as such concurrently trigger load calls on `TransportService` Then, if one of several concurrent calls receives error whole stream with still-executing-plans can be dropped For `NodeBridgeTransport` this would lead to dropping receiver side in `call_raw_js_with_channel_as_callback` But sender side would continue to live in JS thread Then JS side can call `writerOrChannel.resolve`, and it would find that channel is closed, and raise exception But then this exception will be caught, leading to `writerOrChannel.reject` call And because `writerOrChannel.resolve` already consumed channel it would raise its own exception And, because `wrapNativeFunctionWithStream` uses async function, this exception would lead to promise rejection, will not get caught in native part on JS side (it does not care for return values), and can trigger unhandled rejection
mcheshkov
force-pushed
the
native-backend-channel-drop
branch
from
2d0e4c6 to
066787a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made (if issue reference is not provided)
DataFusion can execute complex queries, containing multiple CubeScans, specifically multiple
CubeScanExecutionPlanin physical planCubeScanExecutionPlans can be executed concurrently, and as such concurrently trigger load calls onTransportServiceThen, if one of several concurrent calls receives error whole stream with still-executing-plans can be dropped
For
NodeBridgeTransportthis would lead to dropping receiver side incall_raw_js_with_channel_as_callbackBut sender side would continue to live in JS thread
Then JS side can call
writerOrChannel.resolve, and it would find that channel is closed, and raise exceptionBut then this exception will be caught, leading to
writerOrChannel.rejectcallAnd because
writerOrChannel.resolvealready consumed channel it would raise its own exceptionAnd, because
wrapNativeFunctionWithStreamuses async function, this exception would lead to promise rejection, will not get caught in native part on JS side (it does not care for return values), and can trigger unhandled rejection