Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cubesql): Generate typed null literals #9238

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Conversation

mcheshkov
Copy link
Member

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made (if issue reference is not provided)

This is to avoid expressions like SUM(NULL), which are ambiguous in PostgreSQL

@mcheshkov mcheshkov force-pushed the sql-pushdown-typed-null branch from 051175e to 02ceacc Compare February 18, 2025 14:11
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 60.16949% with 47 lines in your changes missing coverage. Please review.

Project coverage is 83.65%. Comparing base (57932fc) to head (eed7de2).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...t/cubesql/cubesql/src/compile/engine/df/wrapper.rs 41.97% 47 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9238      +/-   ##
==========================================
- Coverage   83.66%   83.65%   -0.01%     
==========================================
  Files         227      227              
  Lines       81688    81773      +85     
==========================================
+ Hits        68346    68409      +63     
- Misses      13342    13364      +22     
Flag Coverage Δ
cubesql 83.65% <60.16%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcheshkov mcheshkov marked this pull request as ready for review February 18, 2025 15:11
@mcheshkov mcheshkov requested a review from a team as a code owner February 18, 2025 15:11
@mcheshkov mcheshkov force-pushed the sql-pushdown-typed-null branch from 02ceacc to 01eac3c Compare February 24, 2025 14:53
@mcheshkov mcheshkov force-pushed the sql-pushdown-typed-null branch 2 times, most recently from b024987 to 699cdb8 Compare February 25, 2025 00:10
This is to avoid expression like SUM(NULL), which are ambiguous in PostgreSQL
@mcheshkov mcheshkov force-pushed the sql-pushdown-typed-null branch from 699cdb8 to eed7de2 Compare February 25, 2025 09:12
@mcheshkov mcheshkov merged commit 1dfa10d into master Feb 25, 2025
83 checks passed
@mcheshkov mcheshkov deleted the sql-pushdown-typed-null branch February 25, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants