fix(cubesql): Generate proper projection wrapper for duplicated members #9233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9233 +/- ##
==========================================
+ Coverage 83.64% 83.65% +0.01%
==========================================
Files 227 227
Lines 81576 81646 +70
==========================================
+ Hits 68234 68304 +70
Misses 13342 13342
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mcheshkov
force-pushed
the
duplicated-members-sql
branch
from
2c3607f to
405dc1f
Compare
mcheshkov
force-pushed
the
duplicated-members-sql
branch
3 times, most recently
from
aa1ff5c to
ee983ad
Compare
MazterQyou
approved these changes
Feb 24, 2025
…rs in CubeScanNode
mcheshkov
force-pushed
the
duplicated-members-sql
branch
from
ee983ad to
053c05e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made (if issue reference is not provided)
CubeScanWrapperNode::generate_sql_for_nodedoes not handle duplicated members inmember_fields. It results in missing realiasing projection, as it generate only one column for each member. This PR introduces realiasing to make those columns reappear.CubeScanExecutionPlanimplements this by iterating overmember_fieldswhile building columns, so each member inmember_fieldswill get it’s own column in DF anyway.