Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(cubesql): Avoid allocations in MetaContext methods #9228

Merged
merged 11 commits into from
Feb 18, 2025

chore(cubesql): Add TODOs about cube.contains_member(&cube.member_nam…

d00c068
Select commit
Loading
Failed to load commit list.
Merged

perf(cubesql): Avoid allocations in MetaContext methods #9228

chore(cubesql): Add TODOs about cube.contains_member(&cube.member_nam…
d00c068
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 18, 2025 in 0s

83.57% (+0.00%) compared to 2dd9a4a

View this Pull Request on Codecov

83.57% (+0.00%) compared to 2dd9a4a

Details

Codecov Report

Attention: Patch coverage is 86.84211% with 10 lines in your changes missing coverage. Please review.

Project coverage is 83.57%. Comparing base (2dd9a4a) to head (d00c068).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
rust/cubesql/cubesql/src/transport/ctx.rs 83.33% 8 Missing ⚠️
...besql/cubesql/src/compile/rewrite/rules/members.rs 66.66% 1 Missing ⚠️
...sql/cubesql/src/compile/rewrite/rules/old_split.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #9228   +/-   ##
=======================================
  Coverage   83.57%   83.57%           
=======================================
  Files         227      227           
  Lines       81627    81615   -12     
=======================================
- Hits        68216    68207    -9     
+ Misses      13411    13408    -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov