fix(schema-compiler): Fix sql generation for rolling_window queries with multiple time dimensions #9124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
KSDaemon
force-pushed
the
fix/drill-down
branch
from
92f6c78 to
9090543
Compare
KSDaemon
changed the title
KSDaemon
force-pushed
the
fix/drill-down
branch
from
9090543 to
27f8a5d
Compare
KSDaemon
force-pushed
the
fix/drill-down
branch
from
27f8a5d to
f44d23d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9124 +/- ##
=======================================
Coverage 83.57% 83.57%
=======================================
Files 227 227
Lines 81647 81652 +5
=======================================
+ Hits 68237 68242 +5
Misses 13410 13410
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
KSDaemon
force-pushed
the
fix/drill-down
branch
4 times, most recently
from
ef0654c to
0b85b0f
Compare
KSDaemon
force-pushed
the
fix/drill-down
branch
from
0b85b0f to
8da32c5
Compare
KSDaemon
force-pushed
the
fix/drill-down
branch
2 times, most recently
from
e90c9b5 to
e51d377
Compare
mcheshkov
approved these changes
Feb 24, 2025
packages/cubejs-schema-compiler/src/adapter/BaseTimeDimension.ts
Outdated
Show resolved
Hide resolved
KSDaemon
force-pushed
the
fix/drill-down
branch
from
e51d377 to
a264de9
Compare
KSDaemon
force-pushed
the
fix/drill-down
branch
from
a264de9 to
063c5fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the incorrect SQL generation for queries that reference measures with rolling_windows and a few (more than one) time timensions with granularities.
Check List