Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cubesql): Upgrade rust to nightly-2024-07-15 #8473

Merged
merged 5 commits into from
Jul 17, 2024

Conversation

ovr
Copy link
Member

@ovr ovr commented Jul 17, 2024

No description provided.

@ovr ovr requested review from a team as code owners July 17, 2024 07:17
Copy link

vercel bot commented Jul 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Jul 17, 2024 10:38am
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Jul 17, 2024 10:38am
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Jul 17, 2024 10:38am
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Jul 17, 2024 10:38am
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Jul 17, 2024 10:38am
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Jul 17, 2024 10:38am
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Jul 17, 2024 10:38am
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Jul 17, 2024 10:38am

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.93%. Comparing base (a2fb38b) to head (64305ae).
Report is 5 commits behind head on master.

Files Patch % Lines
rust/cubesql/cubesql/src/config/injection.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8473      +/-   ##
==========================================
+ Coverage   81.63%   81.93%   +0.29%     
==========================================
  Files         199      199              
  Lines       77428    76073    -1355     
==========================================
- Hits        63212    62327     -885     
+ Misses      14216    13746     -470     
Flag Coverage Δ
cubesql 81.93% <87.50%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@KSDaemon KSDaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 LGTM!)

@ovr ovr merged commit 6a6a7fe into master Jul 17, 2024
66 checks passed
@ovr ovr deleted the feat/cubesql-rust-nightly-2024-07-15 branch July 17, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants