Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cubesql): Use lld linker for linux #8439

Merged
merged 6 commits into from
Jul 15, 2024
Merged

feat(cubesql): Use lld linker for linux #8439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9927355
feat(cubesql): Use lld linker for linux
ovr Jul 8, 2024
30973e9
chore: return back llvm-cov
ovr Jul 15, 2024
ec798d2
chore: bump action
ovr Jul 15, 2024
b144d0f
chore: bump action
ovr Jul 15, 2024
26a054b
chore: try
ovr Jul 15, 2024
c4328fe
chore: use CODECOV_TOKEN
ovr Jul 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion .github/workflows/rust-cubesql.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,14 +67,33 @@ jobs:
# default key
key: cubesql-${{ runner.OS }}-x86_64-unknown-linux-gnu
shared-key: cubesql-${{ runner.OS }}-x86_64-unknown-linux-gnu
- name: Install lld
run: |
# ubuntu 24.04 has lld-18
sudo apt-get update && sudo apt install -y lld
- name: Install [email protected]
uses: baptiste0928/cargo-install@v3
with:
crate: cargo-llvm-cov
version: "0.6.10"
- name: Unit tests (Rewrite Engine)
env:
CUBESQL_TESTING_CUBE_TOKEN: ${{ secrets.CUBESQL_TESTING_CUBE_TOKEN }}
CUBESQL_TESTING_CUBE_URL: ${{ secrets.CUBESQL_TESTING_CUBE_URL }}
CUBESQL_SQL_PUSH_DOWN: true
CUBESQL_REWRITE_CACHE: true
CUBESQL_REWRITE_TIMEOUT: 60
run: cd rust/cubesql && cargo test
run: |
cd rust/cubesql
cargo llvm-cov --all-features --workspace --lcov --output-path lcov.info
- name: Upload code coverage
uses: codecov/codecov-action@v4
with:
token: ${{ secrets.CODECOV_TOKEN }}
files: ./rust/cubesql/lcov.info
verbose: true
flags: cubesql
fail_ci_if_error: false

native_linux:
needs: [lint]
Expand Down
7 changes: 7 additions & 0 deletions packages/cubejs-backend-native/.cargo/config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# Please keep in sync this file with rust/cubesql!

[target."x86_64-unknown-linux-gnu"]
rustflags = ["-C", "link-arg=-fuse-ld=lld"]

[target."aarch64-unknown-linux-gnu"]
rustflags = ["-C", "link-arg=-fuse-ld=lld"]
3 changes: 1 addition & 2 deletions packages/cubejs-backend-native/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,4 @@ target
index.node
**/node_modules
**/.DS_Store
npm-debug.log*
.cargo
npm-debug.log
11 changes: 11 additions & 0 deletions rust/cubesql/.cargo/config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# Please keep in sync this file with packages/cubejs-backend-native!

[target."x86_64-unknown-linux-gnu"]
rustflags = ["-C", "link-arg=-fuse-ld=lld"]

[target."aarch64-unknown-linux-gnu"]
rustflags = ["-C", "link-arg=-fuse-ld=lld"]

# If you are going to use local fork, feel free to uncomment
#paths = ["../../../sqlparser-rs", "../../../arrow-datafusion/datafusion"]
#paths = ["../../../arrow-datafusion/datafusion"]
1 change: 0 additions & 1 deletion rust/cubesql/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
/cubesql/target
/.idea
upstream
.cargo/config.toml
dist
node_modules
.vscode
Expand Down
Loading