Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cubesql): Allow replacement of aggregation functions in SQL push… #7811

Merged
merged 1 commit into from
Feb 25, 2024

Conversation

paveltiunov
Copy link
Member

@paveltiunov paveltiunov commented Feb 25, 2024

… down

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@paveltiunov paveltiunov requested a review from a team as a code owner February 25, 2024 23:15
Copy link

vercel bot commented Feb 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

7 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Feb 25, 2024 11:16pm
examples-react-d3 ⬜️ Ignored (Inspect) Feb 25, 2024 11:16pm
examples-react-data-table ⬜️ Ignored (Inspect) Feb 25, 2024 11:16pm
examples-react-highcharts ⬜️ Ignored (Inspect) Feb 25, 2024 11:16pm
examples-react-material-ui ⬜️ Ignored (Inspect) Feb 25, 2024 11:16pm
examples-react-pivot-table ⬜️ Ignored (Inspect) Feb 25, 2024 11:16pm
examples-vue-query-builder ⬜️ Ignored (Inspect) Feb 25, 2024 11:16pm

Copy link

codecov bot commented Feb 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.99%. Comparing base (b122837) to head (be822a7).

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7811       +/-   ##
===========================================
+ Coverage   47.95%   67.99%   +20.03%     
===========================================
  Files         154      347      +193     
  Lines       20991    58523    +37532     
  Branches     5402     5402               
===========================================
+ Hits        10067    39791    +29724     
- Misses      10176    17984     +7808     
  Partials      748      748               
Flag Coverage Δ
cube-backend 47.95% <ø> (ø)
cubesql 79.19% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paveltiunov paveltiunov merged commit 97fa757 into master Feb 25, 2024
57 checks passed
@paveltiunov paveltiunov deleted the agg-replacement branch February 25, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant