Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cubesql): WHERE SQL push down #7808

Merged
merged 2 commits into from
Feb 24, 2024
Merged

feat(cubesql): WHERE SQL push down #7808

merged 2 commits into from
Feb 24, 2024

Conversation

paveltiunov
Copy link
Member

@paveltiunov paveltiunov commented Feb 24, 2024

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Copy link

vercel bot commented Feb 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Feb 24, 2024 7:59pm
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Feb 24, 2024 7:59pm
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Feb 24, 2024 7:59pm
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Feb 24, 2024 7:59pm
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Feb 24, 2024 7:59pm
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Feb 24, 2024 7:59pm
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Feb 24, 2024 7:59pm
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Feb 24, 2024 7:59pm

@paveltiunov paveltiunov requested review from a team as code owners February 24, 2024 04:31
Copy link

codecov bot commented Feb 24, 2024

Codecov Report

Attention: Patch coverage is 79.51807% with 34 lines in your changes are missing coverage. Please review.

Project coverage is 67.93%. Comparing base (60aad90) to head (411b097).

Files Patch % Lines
...t/cubesql/cubesql/src/compile/engine/df/wrapper.rs 67.50% 13 Missing ⚠️
.../cubejs-schema-compiler/src/adapter/BaseSegment.ts 36.84% 11 Missing and 1 partial ⚠️
...t/cubesql/cubesql/src/compile/rewrite/converter.rs 81.81% 2 Missing ⚠️
packages/cubejs-api-gateway/src/gateway.ts 0.00% 1 Missing ⚠️
...ubejs-schema-compiler/src/adapter/BigqueryQuery.ts 0.00% 1 Missing ⚠️
...ubejs-schema-compiler/src/adapter/PostgresQuery.ts 0.00% 1 Missing ⚠️
...ubejs-schema-compiler/src/adapter/PrestodbQuery.ts 0.00% 1 Missing ⚠️
...bejs-schema-compiler/src/adapter/SnowflakeQuery.ts 0.00% 1 Missing ⚠️
rust/cubesql/cubesql/src/compile/mod.rs 95.83% 1 Missing ⚠️
...ubesql/src/compile/rewrite/rules/wrapper/filter.rs 97.29% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7808      +/-   ##
==========================================
+ Coverage   67.90%   67.93%   +0.02%     
==========================================
  Files         346      347       +1     
  Lines       58296    58443     +147     
  Branches     5394     5402       +8     
==========================================
+ Hits        39588    39704     +116     
- Misses      17961    17991      +30     
- Partials      747      748       +1     
Flag Coverage Δ
cube-backend 47.93% <29.16%> (-0.03%) ⬇️
cubesql 79.14% <88.02%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paveltiunov paveltiunov merged commit 98b5709 into master Feb 24, 2024
67 checks passed
@paveltiunov paveltiunov deleted the where-push-down branch February 24, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant