Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cubesql): Support placeholders in OFFSET, FETCH ... #7807

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

MazterQyou
Copy link
Member

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made

This PR bumps cube-js/sqlparser-rs@347f769 and cube-js/arrow-datafusion@28a07c3, adding support for placeholders in OFFSET and FETCH ... expressions. Related tests are included.

@MazterQyou MazterQyou requested review from a team as code owners February 23, 2024 21:51
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.91%. Comparing base (d9a7194) to head (ff970f8).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7807      +/-   ##
==========================================
- Coverage   67.91%   67.91%   -0.01%     
==========================================
  Files         346      346              
  Lines       58288    58296       +8     
  Branches     5394     5394              
==========================================
+ Hits        39585    39590       +5     
- Misses      17956    17959       +3     
  Partials      747      747              
Flag Coverage Δ
cube-backend 47.95% <ø> (ø)
cubesql 79.12% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MazterQyou MazterQyou merged commit 60aad90 into master Feb 23, 2024
57 checks passed
@MazterQyou MazterQyou deleted the cubesql/offset-fetch-placeholder branch February 23, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant