Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cubesql): Support Z postfix in Timestamp response transformation #7774

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

MazterQyou
Copy link
Member

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made

This PR extends Timestamp response transformation, supporting Z suffix variant.

@MazterQyou MazterQyou requested a review from a team as a code owner February 21, 2024 16:21
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f24554b) 79.12% compared to head (f984ad4) 67.88%.
Report is 5 commits behind head on master.

Files Patch % Lines
rust/cubesql/cubesql/src/compile/engine/df/scan.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7774       +/-   ##
===========================================
- Coverage   79.12%   67.88%   -11.25%     
===========================================
  Files         191      345      +154     
  Lines       37154    58124    +20970     
  Branches        0     5394     +5394     
===========================================
+ Hits        29398    39455    +10057     
- Misses       7756    17922    +10166     
- Partials        0      747      +747     
Flag Coverage Δ
cube-backend 47.95% <ø> (?)
cubesql 79.12% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MazterQyou MazterQyou merged commit c013c91 into master Feb 21, 2024
57 checks passed
@MazterQyou MazterQyou deleted the cubesql/stream-timestamp-z branch February 21, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant