Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cubesql): Allow NULL values in CASE #7761

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Conversation

MazterQyou
Copy link
Member

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made

This PR fixes an issue introduced with 2b7cc30 preventing evaluation of NULL values in CASE expression in some cases.

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (a96831d) 47.95% compared to head (eb32fa0) 67.90%.
Report is 3 commits behind head on master.

Files Patch % Lines
rust/cubesql/cubesql/src/compile/engine/df/scan.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7761       +/-   ##
===========================================
+ Coverage   47.95%   67.90%   +19.94%     
===========================================
  Files         154      345      +191     
  Lines       20920    58074    +37154     
  Branches     5379     5379               
===========================================
+ Hits        10032    39433    +29401     
- Misses      10146    17899     +7753     
  Partials      742      742               
Flag Coverage Δ
cube-backend 47.97% <ø> (+0.02%) ⬆️
cubesql 79.11% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

vercel bot commented Feb 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-react-highcharts 🔄 Building (Inspect) Visit Preview 💬 Add feedback Feb 19, 2024 6:58pm
7 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Feb 19, 2024 6:58pm
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Feb 19, 2024 6:58pm
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Feb 19, 2024 6:58pm
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Feb 19, 2024 6:58pm
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Feb 19, 2024 6:58pm
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Feb 19, 2024 6:58pm
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Feb 19, 2024 6:58pm

@MazterQyou MazterQyou marked this pull request as ready for review February 19, 2024 18:58
@MazterQyou MazterQyou requested review from a team as code owners February 19, 2024 18:58
@MazterQyou MazterQyou merged commit a97acdc into master Feb 19, 2024
55 checks passed
@MazterQyou MazterQyou deleted the cubesql/scatter-null branch February 19, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant