Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cubesql): Support TimestampNanosecond in CASE #7750

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

MazterQyou
Copy link
Member

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made

This PR bumps cube-js/arrow-datafusion@824a1a3, adding support for TimestampNanosecond matching in CASE expressions. Related test is included.
Additionally, a duplicate match case yielding an error has been removed.

@MazterQyou MazterQyou requested review from a team as code owners February 12, 2024 23:16
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (0bc09fd) 67.87% compared to head (f4c986d) 67.88%.
Report is 2 commits behind head on master.

Files Patch % Lines
...t/cubesql/cubesql/src/compile/engine/df/columar.rs 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7750      +/-   ##
==========================================
+ Coverage   67.87%   67.88%   +0.01%     
==========================================
  Files         345      345              
  Lines       57978    58009      +31     
  Branches     5239     5239              
==========================================
+ Hits        39353    39380      +27     
- Misses      18431    18435       +4     
  Partials      194      194              
Flag Coverage Δ
cube-backend 47.98% <ø> (ø)
cubesql 79.11% <93.54%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MazterQyou MazterQyou merged commit 73b5c0d into master Feb 12, 2024
56 checks passed
@MazterQyou MazterQyou deleted the cubesql/case-timestamp-nanosecond branch February 12, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant