Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cubesql): Support new Metabase meta queries #7749

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

MazterQyou
Copy link
Member

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made

This PR improves compatibility with Metabase v48, adding support for pg_catalog.has_table_privilege function. Related tests are included.

@MazterQyou MazterQyou requested a review from a team as a code owner February 12, 2024 19:47
@MazterQyou MazterQyou force-pushed the cubesql/has-table-privilege branch from 963ab3e to 0549509 Compare February 12, 2024 19:51
Copy link

vercel bot commented Feb 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2024 7:51pm
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2024 7:51pm
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2024 7:51pm
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2024 7:51pm
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2024 7:51pm
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2024 7:51pm
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2024 7:51pm
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Feb 12, 2024 7:51pm

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (00c2a6b) 67.84% compared to head (0549509) 67.87%.

Files Patch % Lines
rust/cubesql/cubesql/src/compile/engine/udf.rs 89.65% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7749      +/-   ##
==========================================
+ Coverage   67.84%   67.87%   +0.03%     
==========================================
  Files         345      345              
  Lines       57928    57978      +50     
  Branches     5239     5239              
==========================================
+ Hits        39301    39355      +54     
+ Misses      18433    18429       -4     
  Partials      194      194              
Flag Coverage Δ
cube-backend 47.98% <ø> (ø)
cubesql 79.11% <94.11%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MazterQyou MazterQyou merged commit 0bc09fd into master Feb 12, 2024
58 checks passed
@MazterQyou MazterQyou deleted the cubesql/has-table-privilege branch February 12, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant