Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(native): Handle error without panic (drop unwrap) #7729

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

ovr
Copy link
Member

@ovr ovr commented Feb 5, 2024

Hello!

Thanks

@ovr ovr requested a review from a team as a code owner February 5, 2024 17:55
Copy link

vercel bot commented Feb 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2024 8:33pm
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2024 8:33pm
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2024 8:33pm
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2024 8:33pm
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2024 8:33pm
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2024 8:33pm
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2024 8:33pm
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2024 8:33pm

@ovr ovr force-pushed the fix/native-unwrap-issue branch from 344de00 to f0a94c3 Compare February 5, 2024 17:55
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2b7cc30) 72.82% compared to head (68ef795) 47.97%.
Report is 1 commits behind head on master.

❗ Current head 68ef795 differs from pull request most recent head 612ee8b. Consider uploading reports for the commit 612ee8b to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7729       +/-   ##
===========================================
- Coverage   72.82%   47.97%   -24.85%     
===========================================
  Files         335      154      -181     
  Lines       56996    20915    -36081     
  Branches     5238     5238               
===========================================
- Hits        41509    10035    -31474     
+ Misses      15293    10686     -4607     
  Partials      194      194               
Flag Coverage Δ
cube-backend 47.97% <ø> (ø)
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ovr ovr force-pushed the fix/native-unwrap-issue branch from 26e8634 to dc90724 Compare February 5, 2024 19:29
@ovr ovr force-pushed the fix/native-unwrap-issue branch 2 times, most recently from 68ef795 to 612ee8b Compare February 5, 2024 20:41
@ovr ovr merged commit 5480978 into master Feb 6, 2024
92 of 94 checks passed
@ovr ovr deleted the fix/native-unwrap-issue branch February 6, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant