Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cubesql): Enable constant folding for unary minus exprs #7707

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

MazterQyou
Copy link
Member

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made

This PR enables constant folding for unary minus expressions (-expr), fixing a regression introduced with d5a935a. Related test is included.

@MazterQyou MazterQyou requested a review from a team as a code owner January 31, 2024 16:57
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1938053) 47.95% compared to head (4e5dba3) 72.86%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7707       +/-   ##
===========================================
+ Coverage   47.95%   72.86%   +24.90%     
===========================================
  Files         154      335      +181     
  Lines       20914    56895    +35981     
  Branches     5377     5377               
===========================================
+ Hits        10030    41455    +31425     
- Misses      10143    14699     +4556     
  Partials      741      741               
Flag Coverage Δ
cube-backend 47.98% <ø> (+0.02%) ⬆️
cubesql 87.32% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MazterQyou MazterQyou merged commit 704d05a into master Jan 31, 2024
57 checks passed
@MazterQyou MazterQyou deleted the cubesql/unary-minus-regression-fix branch January 31, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant