Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cubesq): Realiasing issue (relation) on JOIN with SQL push down #7705

Closed
wants to merge 4 commits into from

Conversation

ovr
Copy link
Member

@ovr ovr commented Jan 30, 2024

Hello!

Thanks

@ovr ovr requested a review from a team as a code owner January 30, 2024 12:37
Copy link

vercel bot commented Jan 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2024 5:55pm
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2024 5:55pm
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2024 5:55pm
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2024 5:55pm
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2024 5:55pm
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2024 5:55pm
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2024 5:55pm
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Feb 5, 2024 5:55pm

@ovr ovr marked this pull request as draft January 30, 2024 12:38
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (653f086) 87.30% compared to head (7905525) 47.95%.
Report is 27 commits behind head on master.

❗ Current head 7905525 differs from pull request most recent head 7cda773. Consider uploading reports for the commit 7cda773 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7705       +/-   ##
===========================================
- Coverage   87.30%   47.95%   -39.35%     
===========================================
  Files         181      154       -27     
  Lines       35966    20914    -15052     
  Branches        0     5377     +5377     
===========================================
- Hits        31401    10030    -21371     
- Misses       4565    10143     +5578     
- Partials        0      741      +741     
Flag Coverage Δ
cube-backend 47.95% <ø> (?)
cubesql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ovr ovr force-pushed the fix/cubesql-sql-push-down-realiasing-issue branch from 5ce8478 to be2746a Compare January 30, 2024 14:35
@ovr ovr force-pushed the fix/cubesql-sql-push-down-realiasing-issue branch from 11e0d01 to 7905525 Compare January 30, 2024 16:20
@ovr ovr closed this Mar 13, 2024
@ovr ovr deleted the fix/cubesql-sql-push-down-realiasing-issue branch March 13, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant