Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Merge streaming methods to one interface to allow SQL API use st… #7695

Merged
merged 15 commits into from
Jan 28, 2024

Conversation

paveltiunov
Copy link
Member

@paveltiunov paveltiunov commented Jan 27, 2024

…andard batching used for pre-aggregations

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@paveltiunov paveltiunov requested a review from a team as a code owner January 27, 2024 06:12
Copy link

vercel bot commented Jan 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Jan 28, 2024 6:47pm
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Jan 28, 2024 6:47pm
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Jan 28, 2024 6:47pm
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Jan 28, 2024 6:47pm
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Jan 28, 2024 6:47pm
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Jan 28, 2024 6:47pm
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Jan 28, 2024 6:47pm
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Jan 28, 2024 6:47pm

Copy link

codecov bot commented Jan 27, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (6cbbaa0) 47.96% compared to head (ccd9c2f) 47.98%.
Report is 2 commits behind head on master.

Files Patch % Lines
...-query-orchestrator/src/orchestrator/QueryCache.ts 75.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7695      +/-   ##
==========================================
+ Coverage   47.96%   47.98%   +0.01%     
==========================================
  Files         154      154              
  Lines       20912    20914       +2     
  Branches     5377     5377              
==========================================
+ Hits        10030    10035       +5     
+ Misses      10141    10138       -3     
  Partials      741      741              
Flag Coverage Δ
cube-backend 47.98% <75.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paveltiunov paveltiunov requested a review from a team as a code owner January 27, 2024 20:51
@paveltiunov paveltiunov merged commit 73ad72d into master Jan 28, 2024
51 checks passed
@paveltiunov paveltiunov deleted the sql-api-streaming branch January 28, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant