Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cubesql): Parameterized cache #7670

Merged
merged 2 commits into from
Jan 18, 2024
Merged

feat(cubesql): Parameterized cache #7670

merged 2 commits into from
Jan 18, 2024

Conversation

paveltiunov
Copy link
Member

@paveltiunov paveltiunov commented Jan 18, 2024

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@paveltiunov paveltiunov requested a review from a team as a code owner January 18, 2024 05:12
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (6d27803) 72.71% compared to head (e5e8023) 72.72%.
Report is 1 commits behind head on master.

Files Patch % Lines
...st/cubesql/cubesql/src/compile/rewrite/analysis.rs 82.60% 8 Missing ⚠️
...st/cubesql/cubesql/src/compile/rewrite/rewriter.rs 20.00% 8 Missing ⚠️
rust/cubesql/cubesql/src/compile/rewrite/mod.rs 85.71% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7670   +/-   ##
=======================================
  Coverage   72.71%   72.72%           
=======================================
  Files         330      330           
  Lines       56328    56396   +68     
  Branches     5377     5377           
=======================================
+ Hits        40961    41013   +52     
- Misses      14626    14642   +16     
  Partials      741      741           
Flag Coverage Δ
cube-backend 47.96% <ø> (ø)
cubesql 87.30% <85.08%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paveltiunov paveltiunov merged commit c360d3c into master Jan 18, 2024
57 checks passed
@paveltiunov paveltiunov deleted the parameterized-cache branch January 18, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant