Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cubesql): Compiler cache for rewrite rules #7604

Merged
merged 3 commits into from
Jan 7, 2024

Conversation

paveltiunov
Copy link
Member

@paveltiunov paveltiunov commented Jan 6, 2024

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@paveltiunov paveltiunov requested review from a team as code owners January 6, 2024 02:30
Copy link

vercel bot commented Jan 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Jan 6, 2024 3:42am
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Jan 6, 2024 3:42am
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Jan 6, 2024 3:42am
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Jan 6, 2024 3:42am
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Jan 6, 2024 3:42am
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Jan 6, 2024 3:42am
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Jan 6, 2024 3:42am
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Jan 6, 2024 3:42am

Copy link

codecov bot commented Jan 6, 2024

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (b5d4ccd) 87.40% compared to head (d1a9bd9) 72.78%.
Report is 3 commits behind head on master.

Files Patch % Lines
...cubesql/cubesql/src/compile/test/rewrite_engine.rs 0.00% 9 Missing ⚠️
packages/cubejs-api-gateway/src/sql-server.ts 0.00% 5 Missing ⚠️
...ackages/cubejs-server-core/src/core/CompilerApi.js 57.14% 3 Missing ⚠️
packages/cubejs-api-gateway/src/gateway.ts 88.88% 1 Missing ⚠️
...besql/cubesql/src/compile/rewrite/rules/members.rs 88.88% 1 Missing ⚠️
rust/cubesql/cubesql/src/sql/compiler_cache.rs 97.29% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7604       +/-   ##
===========================================
- Coverage   87.40%   72.78%   -14.62%     
===========================================
  Files         174      329      +155     
  Lines       35310    56294    +20984     
  Branches        0     5379     +5379     
===========================================
+ Hits        30863    40975    +10112     
- Misses       4447    14578    +10131     
- Partials        0      741      +741     
Flag Coverage Δ
cube-backend 48.03% <59.09%> (?)
cubesql 87.41% <94.41%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paveltiunov paveltiunov merged commit 995889f into master Jan 7, 2024
45 checks passed
@paveltiunov paveltiunov deleted the sql-api-compiler-cache branch January 7, 2024 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant