refactor(cubesql): Fix op_ref warning

cube-js · Feb 24, 2025 · 87123c5 · 87123c5
1 parent f01b7b9
commit 87123c5
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 8 deletions.
diff --git a/rust/cubesql/cubesql/Cargo.toml b/rust/cubesql/cubesql/Cargo.toml
@@ -119,7 +119,6 @@ new_without_default = "allow"
 non_canonical_partial_ord_impl = "allow"
 nonminimal_bool = "allow"
 only_used_in_recursion = "allow"
-op_ref = "allow"
 option_as_ref_deref = "allow"
 partialeq_ne_impl = "allow"
 ptr_arg = "allow"

diff --git a/rust/cubesql/cubesql/src/compile/engine/df/wrapper.rs b/rust/cubesql/cubesql/src/compile/engine/df/wrapper.rs
@@ -1322,13 +1322,13 @@ impl CubeScanWrapperNode {
                                                         let aliased_column = aggr_expr
                                                             .iter()
                                                             .find_position(|e| {
-                                                                expr_name(e, &schema).map(|n| &n == &col_name).unwrap_or(false)
+                                                                expr_name(e, &schema).map(|n| n == col_name).unwrap_or(false)
                                                             })
                                                             .map(|(i, _)| aggregate[i].clone()).or_else(|| {
                                                             projection_expr
                                                                 .iter()
                                                                 .find_position(|e| {
-                                                                    expr_name(e, &schema).map(|n| &n == &col_name).unwrap_or(false)
+                                                                    expr_name(e, &schema).map(|n| n == col_name).unwrap_or(false)
                                                                 })
                                                                 .map(|(i, _)| {
                                                                     projection[i].clone()
@@ -1337,7 +1337,7 @@ impl CubeScanWrapperNode {
                                                             flat_group_expr
                                                                 .iter()
                                                                 .find_position(|e| {
-                                                                    expr_name(e, &schema).map(|n| &n == &col_name).unwrap_or(false)
+                                                                    expr_name(e, &schema).map(|n| n == col_name).unwrap_or(false)
                                                                 })
                                                                 .map(|(i, _)| group_by[i].clone())
                                                         }).ok_or_else(|| {

diff --git a/rust/cubesql/cubesql/src/compile/engine/udf/common.rs b/rust/cubesql/cubesql/src/compile/engine/udf/common.rs
@@ -815,7 +815,7 @@ pub fn create_convert_tz_udf() -> ScalarUDF {
         }
 
         if let Some(tz) = input_tz {
-            if tz != &"UTC" {
+            if tz != "UTC" {
                 return Err(DataFusionError::NotImplemented(format!(
                     "convert_tz does not non UTC timezone as input, actual {}",
                     tz

diff --git a/rust/cubesql/cubesql/src/compile/rewrite/mod.rs b/rust/cubesql/cubesql/src/compile/rewrite/mod.rs
@@ -691,7 +691,7 @@ impl LogicalPlanData {
         {
             {
                 let column_name = expr_column_name(&expr, &None);
-                let equal = name == &column_name;
+                let equal = name == column_name;
                 let _ = member_names_to_expr
                     .cached_lookups
                     .try_insert(column_name, index);
@@ -702,7 +702,7 @@ impl LogicalPlanData {
             }
             {
                 let column_name = expr_column_name_with_relation(&expr, &mut relation);
-                let equal = name == &column_name;
+                let equal = name == column_name;
                 let _ = member_names_to_expr
                     .cached_lookups
                     .try_insert(column_name, index);

diff --git a/rust/cubesql/cubesql/src/sql/postgres/writer.rs b/rust/cubesql/cubesql/src/sql/postgres/writer.rs
@@ -64,7 +64,7 @@ impl ToProtocolValue for TimestampValue {
 
         match self.tz_ref() {
             None => as_str.to_text(buf),
-            Some(_) => (as_str + &"+00").to_text(buf),
+            Some(_) => (as_str + "+00").to_text(buf),
         }
     }