Skip to content

Commit

Permalink
chore(cubesql): Add TODOs about cube.contains_member(&cube.member_nam…
Browse files Browse the repository at this point in the history
…e(...))
  • Loading branch information
mcheshkov committed Feb 17, 2025
1 parent f1a6fac commit 1d481c5
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions rust/cubesql/cubesql/src/transport/ctx.rs
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ impl MetaContext {
} else {
alias_to_cube.iter().find(|(_, c)| {
if let Some(cube) = self.find_cube_with_name(c) {
// TODO replace cube.contains_member(&cube.member_name(...)) with searching by prepared column names
cube.contains_member(&cube.member_name(&column.name))
} else {
false
Expand Down Expand Up @@ -135,6 +136,7 @@ impl MetaContext {
.iter()
.filter_map(|((old, new), c)| {
if let Some(cube) = self.find_cube_with_name(c) {
// TODO replace cube.contains_member(&cube.member_name(...)) with searching by prepared column names
if cube.contains_member(&cube.member_name(&column.name)) {
return Some(((old.as_str(), new.as_str()), cube));

Check warning on line 141 in rust/cubesql/cubesql/src/transport/ctx.rs

View check run for this annotation

Codecov / codecov/patch

rust/cubesql/cubesql/src/transport/ctx.rs#L141

Added line #L141 was not covered by tests
}
Expand Down

0 comments on commit 1d481c5

Please sign in to comment.