chore: more tests

cube-js · Feb 26, 2025 · 1249ae8 · 1249ae8
1 parent 55cc04c
commit 1249ae8
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/packages/cubejs-backend-native/test/__snapshots__/jinja.test.ts.snap b/packages/cubejs-backend-native/test/__snapshots__/jinja.test.ts.snap
@@ -186,7 +186,9 @@ exports[`Jinja (new api) render arguments-test.yml.jinja: arguments-test.yml.jin
   arg_seq_2: [5,4,3,2,1]
   arg_sum_tuple: 3
   arg_sum_map: 20
-  arg_kwargs: \\"arg1: first value, arg2: second value, kwarg:(3 arg4 arg)\\""
+  arg_kwargs1: \\"arg1: first value, arg2: second value, kwarg:(3 arg)\\"
+  arg_kwargs2: \\"arg1: first value, arg2: second value, kwarg:(3 arg,4 arg)\\"
+  arg_kwargs3: \\"arg1: first value, arg2: second value, kwarg:(3 arg,4 arg,4 arg)\\""
 `;
 
 exports[`Jinja (new api) render data-model.yml.jinja: data-model.yml.jinja 1`] = `
@@ -250,7 +252,7 @@ dump:
 exports[`Jinja (new api) render template_error_python.jinja: template_error_python.jinja 1`] = `
 [Error: could not render block: Call error: Python error: Exception: Random Exception
 Traceback (most recent call last):
-  File "jinja-instance.py", line 119, in throw_exception
+  File "jinja-instance.py", line 116, in throw_exception
 
 ------------------------- template_error_python.jinja -------------------------
    3 | 3

diff --git a/packages/cubejs-backend-native/test/templates/arguments-test.yml.jinja b/packages/cubejs-backend-native/test/templates/arguments-test.yml.jinja
@@ -15,4 +15,6 @@ test:
   arg_seq_2: {{ arg_seq(my_sequence_2) }}
   arg_sum_tuple: {{ arg_sum_tuple(my_int_tuple) }}
   arg_sum_map: {{ arg_sum_map(my_map) }}
-  arg_kwargs: {{ arg_kwargs("first value", "second value", three="3 arg", four="4 arg") }}
+  arg_kwargs1: {{ arg_kwargs("first value", "second value", three="3 arg") }}
+  arg_kwargs2: {{ arg_kwargs("first value", "second value", three="3 arg", four="4 arg") }}
+  arg_kwargs3: {{ arg_kwargs("first value", "second value", three="3 arg", four="4 arg", five="4 arg") }}
diff --git a/packages/cubejs-backend-native/test/templates/jinja-instance.py b/packages/cubejs-backend-native/test/templates/jinja-instance.py
@@ -35,10 +35,7 @@ def arg_sum_map(obj):
 
 @template.function
 def arg_kwargs(arg1, arg2, **kwargs):
-    kwargs_str = ""
-
-    for arg in kwargs.values():
-        kwargs_str += arg
+    kwargs_str = ",".join(kwargs.values())
 
     return "arg1: " + arg1 + ", arg2: " + arg2 + ", kwarg:(" + kwargs_str + ")"