Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for react context from react@~16.6.0 #46

Merged
merged 1 commit into from
Nov 23, 2018

Conversation

SleepWalker
Copy link
Contributor

Closes #45

See #45 for details

@SleepWalker
Copy link
Contributor Author

SleepWalker commented Nov 21, 2018

@ctrlplusb can you please look at this PR? It is really important, because without it it is impossible to use react-tree-walker with context from [email protected]

@codecov
Copy link

codecov bot commented Nov 21, 2018

Codecov Report

Merging #46 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
+ Coverage   96.11%   96.19%   +0.07%     
==========================================
  Files           1        1              
  Lines         103      105       +2     
  Branches       31       33       +2     
==========================================
+ Hits           99      101       +2     
  Misses          4        4
Impacted Files Coverage Δ
src/index.js 96.19% <100%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fd7257...2be546d. Read the comment docs.

@SleepWalker SleepWalker force-pushed the fix-react-16.6-context branch from bc7fea5 to 2be546d Compare November 22, 2018 14:04
@ctrlplusb
Copy link
Owner

Thanks for this @SleepWalker!!

@ctrlplusb ctrlplusb merged commit fd6d1fc into ctrlplusb:master Nov 23, 2018
@dan-lee
Copy link
Contributor

dan-lee commented Dec 1, 2018

@ctrlplusb Could you release a new version? Would be great 🎉

Should also solve #40, right?

@jcampalo
Copy link

jcampalo commented Dec 3, 2018

Please release this.

@oyeanuj
Copy link

oyeanuj commented Dec 30, 2018

@jcampalo @dan-lee @SleepWalker Are you maintaining a released fork of this by any chance?

@SleepWalker
Copy link
Contributor Author

SleepWalker commented Dec 30, 2018 via email

@exah
Copy link

exah commented Jan 3, 2019

@oyeanuj you can install @exah/react-tree-walker with included fix, but I will likely copy depended code from package in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants