Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix static plugin integration test failures #45

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Fix static plugin integration test failures #45

merged 2 commits into from
Mar 12, 2024

Conversation

ikaneshiro
Copy link
Contributor

@ikaneshiro ikaneshiro commented Mar 12, 2024 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Bug Fixes
    • Improved error handling in the build process to accurately report when a test suite fails.
  • Refactor
    • Updated import paths and references in the mirror plugin for better alignment with external packages.

@ikaneshiro
Integration Tests: Ensure failures return non-zero exit status
6b9e8c5 
Currently failed integration test runs return a 0 exit status and do not trigger CI failures.

This uses string parsting to detect failures because non-zero exit statuses in dagger containers truncate output:
  https://pkg.go.dev/github.com/dagger/dagger/engine/buildkit#:~:text=MaxExecErrorOutputBytes
@ikaneshiro
Mirror Plugin: Fix registered mediaTypes
3f02272 
Accidental registration of the static file mediaType caused integration test failures
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 12, 2024 •
edited
Loading

Walkthrough

The recent updates introduce a crucial check in the printOutput function to detect and report test suite failures, enhancing error handling and feedback for developers. Additionally, there's a notable update in the mirror plugin, involving the adjustment of import paths and references, aligning with the latest package structure for better efficiency and clarity in code management.

Changes

Files Change Summary
build/mage/common.go Added a check for "Test Suite Failed\n" in printOutput, returning an error on this condition.
internal/plugins/mirror/plugin.go Updated import path and adjusted reference for MirrorFileConfigType in the mirror plugin.

🐰✨
In the code's vast warren, beneath the digital sky,
A rabbit hopped with updates, oh me, oh my!
"Test suites now whisper when they fall,
And mirrors reflect the newest call.
Let's hop to the rhythm of the code's own beat,
With every line, our challenges we meet."
🌟🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

coderabbitai[bot]
coderabbitai bot reviewed Mar 12, 2024
View reviewed changes
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 8cef299 and 3f02272.
Files selected for processing (2)
  • build/mage/common.go (1 hunks)
  • internal/plugins/mirror/plugin.go (2 hunks)
Additional comments: 3
internal/plugins/mirror/plugin.go (2)
  • 29-29: The update of the import path from orasfile to orasmirror is aligned with the PR objectives, indicating a reorganization or refactoring of the codebase. This change appears to be correctly implemented.
  • 95-95: The adjustment from orasfile.StaticFileConfigType to orasmirror.MirrorFileConfigType is consistent with the import path change and reflects a shift in functionality or structure. This change is correctly implemented and aligns with the PR objectives.
build/mage/common.go (1)
  • 113-117: The addition of a check for the string "Test Suite Failed\n" in the printOutput function is aligned with the PR objectives. It enhances error detection and reporting mechanisms during the test execution process. This change is correctly implemented and should improve the clarity and effectiveness of test failure notifications.

@kyleishie kyleishie merged commit 42d50ed into main Mar 12, 2024
3 checks passed
@ikaneshiro ikaneshiro deleted the fix-integration-tests branch March 12, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ikaneshiro @kyleishie